-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove probe-time null equality parameters in cudf::hash_join
#10260
Remove probe-time null equality parameters in cudf::hash_join
#10260
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10260 +/- ##
=============================================
Coverage 10.42% 10.43%
=============================================
Files 119 122 +3
Lines 20603 20583 -20
=============================================
- Hits 2148 2147 -1
+ Misses 18455 18436 -19
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
@PointKernel this is a breaking change, as the public API of I've updated the Java build for this breaking change in #10268. Feel free to cherry-pick that commit to this PR, or we can merge the other PR after this one is merged (Java CI failures are currently non-blocking). |
@jlowe Thanks for doing the java changes. I was replying to your java follow-up PR and then noticed your message here. If you don't mind, I will merge your java commits here to make sure CI tests can pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the java/JNI code
@gpucibot merge |
Closes #9155
This PR removes the probe-time
cudf::null_equality
parameter incudf::hash_join
to avoid potential mismatching bugs between building and probing a hash join object.