Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add more nvtx annotations #10256

Merged
merged 12 commits into from
Feb 11, 2022
Merged

Conversation

galipremsagar
Copy link
Contributor

This PR adds more nvtx annotations for cudf & dask_cudf APIs.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 9, 2022
@galipremsagar galipremsagar self-assigned this Feb 9, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner February 9, 2022 16:59
@galipremsagar galipremsagar requested a review from a team as a code owner February 9, 2022 16:59
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #10256 (e201d11) into branch-22.04 (a7d88cd) will increase coverage by 0.25%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10256      +/-   ##
================================================
+ Coverage         10.42%   10.68%   +0.25%     
================================================
  Files               119      122       +3     
  Lines             20603    20852     +249     
================================================
+ Hits               2148     2228      +80     
- Misses            18455    18624     +169     
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/main.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/comm/gpuarrow.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/methods.py 0.00% <0.00%> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 927ebcb...e201d11. Read the comment docs.

Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. It would have been great to be able to use a class decorator instead but nvtx doesn't have one :-(

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 48c4dc3 into rapidsai:branch-22.04 Feb 11, 2022
@vyasr vyasr added dask Dask issue 4 - Needs Review Waiting for reviewer to review or respond and removed dask-cudf labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants