Fix groupby reductions that perform operations on source type instead of target type #10250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
bug
jlowe
reviewed
Feb 8, 2022
ttnghia
requested review from
nvdbaranec,
rwlee,
mythrocks and
hyperbolic2346
This comment was marked as off-topic.
This comment was marked as off-topic.
ttnghia
removed request for
robertmaynard,
cwharris,
hyperbolic2346,
mythrocks,
rwlee,
jrhemstad and
codereport
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In groupby reductions, some operations such as SUM on integers have the output type different from the source type. For example, target type is int64 while the source type is int32. This is to prevent overflow of the computation result.
This fixes a bug in groupby reductions that perform computation using the data in source type instead of target type.
Closes #10246.