Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small leak in explode #10245

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Feb 8, 2022

This fixes #10244 you can look at that for the analysis of the bug.

@revans2 revans2 added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Feb 8, 2022
@revans2 revans2 requested a review from a team as a code owner February 8, 2022 13:50
@revans2 revans2 self-assigned this Feb 8, 2022
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #10245 (adbea69) into branch-22.04 (a7d88cd) will increase coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head adbea69 differs from pull request most recent head 53882f0. Consider uploading reports for the commit 53882f0 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10245      +/-   ##
================================================
+ Coverage         10.42%   10.45%   +0.03%     
================================================
  Files               119      122       +3     
  Lines             20603    20527      -76     
================================================
- Hits               2148     2147       -1     
+ Misses            18455    18380      -75     
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/main.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/comm/gpuarrow.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/methods.py 0.00% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bc3727...53882f0. Read the comment docs.

@revans2
Copy link
Contributor Author

revans2 commented Feb 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4a50a63 into rapidsai:branch-22.04 Feb 8, 2022
@revans2 revans2 deleted the explode_leak branch February 8, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] explode leaks a host memory
3 participants