Yet another small JNI memory leak #10238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
added
bug
jlowe
approved these changes
Feb 7, 2022
kuhushukla
approved these changes
Feb 7, 2022
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10238 +/- ##
================================================
- Coverage 10.42% 9.75% -0.68%
================================================
Files 119 122 +3
Lines 20603 22013 +1410
================================================
- Hits 2148 2147 -1
- Misses 18455 19866 +1411
Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this is the last one, and this one only happens when we have an empty column vector (no rows). So much less common. I will be running more tests to check/verify a lot of this.