Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Change pytest distribution algorithm and increase parallelism in CI #10232

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Feb 7, 2022

This PR increases the number of cores allocated to pytest-xdist and also changes distribution algorithm for cudf to loadscope.

This PR:

custreamz:
= 600 passed, 6 skipped, 145 xfailed, 96 xpassed, 7 warnings in 88.10s (0:01:28) =

dask-cudf:
= 891 passed, 13 skipped, 2 xfailed, 1 xpassed, 115 warnings in 63.42s (0:01:03) =

cudf(loadscope):
= 88743 passed, 2408 skipped, 985 xfailed, 1978 xpassed, 3115 warnings in 1195.87s (0:19:55) =

branch-22.04:


custreamz:

= 600 passed, 6 skipped, 145 xfailed, 96 xpassed, 5 warnings in 102.16s (0:01:42) =

dask-cudf:

= 891 passed, 13 skipped, 2 xfailed, 1 xpassed, 113 warnings in 78.00s (0:01:18) =

cudf:

= 88745 passed, 2408 skipped, 985 xfailed, 1978 xpassed, 3113 warnings in 2249.52s (0:37:29) =

@galipremsagar galipremsagar requested a review from a team as a code owner February 7, 2022 16:43
@galipremsagar galipremsagar added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 7, 2022
@github-actions github-actions bot added gpuCI and removed Python Affects Python cuDF API. labels Feb 7, 2022
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #10232 (ebb6df8) into branch-22.04 (a7d88cd) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10232      +/-   ##
================================================
+ Coverage         10.42%   10.47%   +0.04%     
================================================
  Files               119      122       +3     
  Lines             20603    20502     -101     
================================================
- Hits               2148     2147       -1     
+ Misses            18455    18355     -100     
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/main.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/comm/gpuarrow.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e458b9...ebb6df8. Read the comment docs.

ci/gpu/build.sh Outdated Show resolved Hide resolved
ci/gpu/build.sh Outdated Show resolved Hide resolved
ci/gpu/build.sh Outdated Show resolved Hide resolved
@galipremsagar galipremsagar self-assigned this Feb 7, 2022
@galipremsagar galipremsagar changed the title Change pytest distribution algo [REVIEW] Change pytest distribution algorithm and increase parallelism in CI Feb 7, 2022
@galipremsagar galipremsagar requested a review from shwina February 7, 2022 21:25
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in Slack thread -- looks good to me, and appears to cut the runtime by 45%. As long as 8 cores doesn't thrash the machine in a way that negatively affects other CI things (e.g. logging? background processes?) or lead to GPU out-of-memory errors, this looks good to me.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Feb 7, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9c85584 into rapidsai:branch-22.04 Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants