Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bitmask of the output for JNI of lists::drop_list_duplicates #10210

Merged
merged 10 commits into from
Feb 4, 2022
Merged

Fix bitmask of the output for JNI of lists::drop_list_duplicates #10210

merged 10 commits into from
Feb 4, 2022

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Feb 3, 2022 •
edited
Loading

Previously, the Spark-rapids plugin only needs to call lists::drop_list_duplicates to create map which requires the input to be non-nullable. As such, the output of the JNI is just a lists column without bitmask. When operating on nullable input lists column, it produces incorrect results.

This PR fixes that.

@ttnghia ttnghia added bug Something isn't working 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Feb 3, 2022
@ttnghia ttnghia requested a review from andygrove February 3, 2022 20:31
@ttnghia ttnghia self-assigned this Feb 3, 2022
@ttnghia ttnghia requested a review from a team as a code owner February 3, 2022 20:31
@ttnghia ttnghia changed the title Fix bitmask of the output for JNI of lists::drop_list_duplicates Fix bitmask of the output for JNI of lists::drop_list_duplicates [skip ci] Feb 3, 2022
@ttnghia ttnghia mentioned this pull request Feb 3, 2022
Merged
@ttnghia ttnghia changed the title Fix bitmask of the output for JNI of lists::drop_list_duplicates [skip ci] Fix bitmask of the output for JNI of lists::drop_list_duplicates Feb 3, 2022
jlowe
jlowe reviewed Feb 3, 2022
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, but it would be nice to update the tests to verify the functionality and ensure the fix does not regress.

@ttnghia ttnghia requested a review from jlowe February 3, 2022 22:13
@codecov

This comment was marked as off-topic.

Sign in to view
@ttnghia
Copy link
Contributor Author

ttnghia commented Feb 4, 2022

Rerun tests.

@ttnghia
Copy link
Contributor Author

ttnghia commented Feb 4, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b72c79d into rapidsai:branch-22.04 Feb 4, 2022
@ttnghia ttnghia deleted the fix__jni_drop_list_duplicates branch February 4, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@andygrove andygrove Awaiting requested review from andygrove

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttnghia @jlowe