Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary nunique function in Series. #10205

Merged

Conversation

martinfalisse
Copy link
Contributor

Removes unnecessary nunique function in Series, as indicated by @vyasr here #10077 (comment).

Seem to have made a mistake when correcting the style of my last commit and not have kept the original changes of that commit.

@martinfalisse martinfalisse requested a review from a team as a code owner February 3, 2022 08:34
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 3, 2022
@vyasr vyasr added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Feb 3, 2022
@quasiben
Copy link
Member

quasiben commented Feb 3, 2022

ok to test

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack @martinfalisse and this is why we don't force push :) Thank you for the quick fix!

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #10205 (a02915f) into branch-22.04 (a7d88cd) will increase coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head a02915f differs from pull request most recent head 3c9d7e7. Consider uploading reports for the commit 3c9d7e7 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10205      +/-   ##
================================================
+ Coverage         10.42%   10.47%   +0.05%     
================================================
  Files               119      122       +3     
  Lines             20603    20501     -102     
================================================
  Hits               2148     2148              
+ Misses            18455    18353     -102     
Impacted Files Coverage Δ
python/cudf/cudf/core/_base_index.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/timedelta.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column_accessor.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a25a2ec...3c9d7e7. Read the comment docs.

@vyasr
Copy link
Contributor

vyasr commented Feb 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8fbd797 into rapidsai:branch-22.04 Feb 3, 2022
@martinfalisse martinfalisse deleted the nunique_series_cleanup branch May 7, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants