Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fixed_point binary operation documentation #10198

Merged
merged 3 commits into from
Feb 3, 2022

Conversation

codereport
Copy link
Contributor

As pointed out by @bdice in #10179, the docs are backwards for some of the binary operations on fixed_point. This PR fixes them and removes the <br> HTML tag as well.

@codereport codereport added 3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond non-breaking Non-breaking change labels Feb 2, 2022
@codereport codereport requested a review from a team as a code owner February 2, 2022 21:30
@codereport codereport self-assigned this Feb 2, 2022
@codereport codereport requested a review from davidwendt February 2, 2022 21:38
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I was very confused when reading #10179, relying on the docs with no background knowledge. 😆

@codereport
Copy link
Contributor Author

Thanks for the fix! I was very confused when reading #10179, relying on the docs with no background knowledge. laughing

Thanks for catching this! It gets confusing when switch between C++ and other languages which are the opposite and I clearly have worked on this for too long to notice that the wording was backwards.

@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Feb 2, 2022
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM FWIW.

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@b6bb463). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 49a49d2 differs from pull request most recent head 057365e. Consider uploading reports for the commit 057365e to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04   #10198   +/-   ##
===============================================
  Coverage                ?   10.48%           
===============================================
  Files                   ?      122           
  Lines                   ?    20496           
  Branches                ?        0           
===============================================
  Hits                    ?     2148           
  Misses                  ?    18348           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6bb463...057365e. Read the comment docs.

@codereport
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7d88a87 into rapidsai:branch-22.04 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants