-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fixed_point
binary operation documentation
#10198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! I was very confused when reading #10179, relying on the docs with no background knowledge. 😆
Thanks for catching this! It gets confusing when switch between C++ and other languages which are the opposite and I clearly have worked on this for too long to notice that the wording was backwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM FWIW.
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10198 +/- ##
===============================================
Coverage ? 10.48%
===============================================
Files ? 122
Lines ? 20496
Branches ? 0
===============================================
Hits ? 2148
Misses ? 18348
Partials ? 0 Continue to review full report at Codecov.
|
@gpucibot merge |
As pointed out by @bdice in #10179, the docs are backwards for some of the binary operations on
fixed_point
. This PR fixes them and removes the<br>
HTML tag as well.