Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cuco pair issue in hash join #10195

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Fix cuco pair issue in hash join #10195

merged 2 commits into from
Feb 3, 2022

Conversation

PointKernel
Copy link
Member

This PR fixes the cuCollections pair issue via NVIDIA/cuCollections#138 thus we don't have to pass rvalues to cuco::make_pair.

@PointKernel PointKernel added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 2, 2022
@PointKernel PointKernel requested a review from vyasr February 2, 2022 20:21
@PointKernel PointKernel requested a review from a team as a code owner February 2, 2022 20:21
@PointKernel PointKernel self-assigned this Feb 2, 2022
@PointKernel PointKernel requested a review from trxcllnt February 2, 2022 20:21
vyasr
vyasr reviewed Feb 2, 2022
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make the changes here and here? I do aim to refactor these to avoid the duplication but we may as well fix the calls now.

@codecov
Copy link

codecov bot commented Feb 2, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@b6bb463). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04   #10195   +/-   ##
===============================================
  Coverage                ?   10.48%           
===============================================
  Files                   ?      122           
  Lines                   ?    20496           
  Branches                ?        0           
===============================================
  Hits                    ?     2148           
  Misses                  ?    18348           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6bb463...554d57b. Read the comment docs.

@vyasr vyasr self-requested a review February 3, 2022 00:11
@vyasr
Copy link
Contributor

vyasr commented Feb 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a10d24a into rapidsai:branch-22.04 Feb 3, 2022
@PointKernel PointKernel deleted the join/fix-cuco-pair-issue branch May 26, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@trxcllnt trxcllnt trxcllnt approved these changes

Assignees

@PointKernel PointKernel

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PointKernel @vyasr @trxcllnt