Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Replace dask groupby .index usages with .by #10193

Merged
merged 1 commit into from
Feb 2, 2022
Merged

[REVIEW] Replace dask groupby .index usages with .by #10193

merged 1 commit into from
Feb 2, 2022

Conversation

galipremsagar
Copy link
Contributor

Dask deprecated index property in GroupBy class: dask/dask#8441, this PR changes the usages to .by

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 2, 2022
@galipremsagar galipremsagar self-assigned this Feb 2, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner February 2, 2022 19:36
@galipremsagar galipremsagar changed the title [REVIEW] Replace dask groupby .index usages with .by [REVIEW] Replace dask groupby .index usages with .by Feb 2, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 2, 2022
quasiben
quasiben approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@quasiben quasiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I confirmed by checking git grep --line-number 'self.index,'

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer labels Feb 2, 2022
@codecov
Copy link

codecov bot commented Feb 2, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@8d2a9cc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04   #10193   +/-   ##
===============================================
  Coverage                ?   10.48%           
===============================================
  Files                   ?      122           
  Lines                   ?    20496           
  Branches                ?        0           
===============================================
  Hits                    ?     2148           
  Misses                  ?    18348           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2a9cc...e05b95d. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit deb902a into rapidsai:branch-22.04 Feb 2, 2022
@vyasr vyasr added dask Dask issue and removed dask-cudf labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasiben quasiben quasiben approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @quasiben @vyasr