Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex flags to strings extract function #10192

Merged

Conversation

davidwendt
Copy link
Contributor

Add the regex_flags parameter to the strings extract() functions so that matching regex patterns is consistent other strings regex APIs.

This also renames the cudf::strings::extract_all API function to cudf::strings::extract_all_record to be consistent with the other _record APIs that return a List column. This is in anticipation of supporting extractall as requested in #7908

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 2, 2022
@davidwendt davidwendt self-assigned this Feb 2, 2022
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #10192 (a253b05) into branch-22.04 (a7d88cd) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-22.04   #10192   +/-   ##
=============================================
  Coverage         10.42%   10.43%           
=============================================
  Files               119      122    +3     
  Lines             20603    20583   -20     
=============================================
- Hits               2148     2147    -1     
+ Misses            18455    18436   -19     
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/main.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/comm/gpuarrow.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/methods.py 0.00% <0.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 927ebcb...a253b05. Read the comment docs.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 3, 2022
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Feb 3, 2022
@davidwendt davidwendt marked this pull request as ready for review February 3, 2022 14:59
@davidwendt davidwendt requested review from a team as code owners February 3, 2022 14:59
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor comment.

cpp/tests/strings/extract_tests.cpp Outdated Show resolved Hide resolved
@harrism harrism removed their request for review February 8, 2022 01:02
@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d5b2448 into rapidsai:branch-22.04 Feb 10, 2022
@davidwendt davidwendt deleted the add-regex-flags-to-extract branch February 10, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API. strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants