-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regex flags to strings extract function #10192
Add regex flags to strings extract function #10192
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10192 +/- ##
=============================================
Coverage 10.42% 10.43%
=============================================
Files 119 122 +3
Lines 20603 20583 -20
=============================================
- Hits 2148 2147 -1
+ Misses 18455 18436 -19
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One minor comment.
@gpucibot merge |
Add the
regex_flags
parameter to the stringsextract()
functions so that matching regex patterns is consistent other strings regex APIs.This also renames the
cudf::strings::extract_all
API function tocudf::strings::extract_all_record
to be consistent with the other_record
APIs that return a List column. This is in anticipation of supportingextractall
as requested in #7908