Add CMake install rule for tests
#10190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a CMake `install` rule for test targets. This step is a prerequisite to being able to package tests in their own `conda` package, which will enable us to deprecate _Project Flash_.
ajschmidt8
added
improvement
github-actions
bot
added
CMake
ttnghia
approved these changes
Feb 2, 2022
robertmaynard
requested changes
Feb 2, 2022
There was a problem hiding this comment.
We need to also change the tests to have a INSTALL_RPATH target property of "\$ORIGIN/../lib" so that they can be run after installation.
--- a/cpp/tests/CMakeLists.txt
+++ b/cpp/tests/CMakeLists.txt
@@ -22,7 +22,9 @@ function(ConfigureTest CMAKE_TEST_NAME)
set_target_properties(
${CMAKE_TEST_NAME} PROPERTIES RUNTIME_OUTPUT_DIRECTORY
"$<BUILD_INTERFACE:${CUDF_BINARY_DIR}/gtests>"
+ INSTALL_RPATH "\$ORIGIN/../lib"
)
+
robertmaynard
approved these changes
Feb 2, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10190 +/- ##
===============================================
Coverage ? 10.47%
===============================================
Files ? 122
Lines ? 20502
Branches ? 0
===============================================
Hits ? 2147
Misses ? 18355
Partials ? 0 Continue to review full report at Codecov.
|
robertmaynard
approved these changes
Feb 7, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CMake
installrule for test targets. This step is a prerequisite to being able to package tests in their owncondapackage, which will enable us to deprecate Project Flash.