[FEA] Add file size counter to cuIO benchmarks #10154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
feature request
|
Sample output: |
vuule
commented
Jan 28, 2022
cpp/benchmarks/io/csv/csv_reader.cpp
Outdated
| @@ -132,6 +130,7 @@ void BM_csv_read_varying_options(benchmark::State& state) | |||
| auto const data_processed = data_size * cols_to_read.size() / view.num_columns(); | |||
| state.SetBytesProcessed(data_processed * state.iterations()); | |||
| state.counters["peak_memory_usage"] = mem_stats_logger.peak_memory_usage(); | |||
| state.counters["file_size"] = source_sink.size(); | |||
There was a problem hiding this comment.
or "encoded_size" maybe?
There was a problem hiding this comment.
"encoded_file_size" ?
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10154 +/- ##
================================================
+ Coverage 10.37% 10.48% +0.10%
================================================
Files 119 122 +3
Lines 20149 20493 +344
================================================
+ Hits 2091 2148 +57
- Misses 18058 18345 +287
Continue to review full report at Codecov.
|
|
CC @GregoryKimball who sort of asked for this feature |
cpp/benchmarks/io/csv/csv_reader.cpp
Outdated
| @@ -132,6 +130,7 @@ void BM_csv_read_varying_options(benchmark::State& state) | |||
| auto const data_processed = data_size * cols_to_read.size() / view.num_columns(); | |||
| state.SetBytesProcessed(data_processed * state.iterations()); | |||
| state.counters["peak_memory_usage"] = mem_stats_logger.peak_memory_usage(); | |||
| state.counters["file_size"] = source_sink.size(); | |||
There was a problem hiding this comment.
"encoded_file_size" ?
rgsl888prabhu
approved these changes
Jan 28, 2022
harrism
approved these changes
Jan 29, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most cuIO benchmarks used dataframes of fixed size as input. After writing to a file in the given format, its size can vary greatly depending on the encoding and compression.
This PR adds a counter to output the file size, as it can be often corelated with the performance of readers/writers.