Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
byte_range support for multibyte_split/read_text #10150
byte_range support for multibyte_split/read_text #10150
Changes from 37 commits
a220545
53a6416
5f7435c
b7022d9
5142593
8fa93bf
03ff0c4
258259d
5610855
769864d
73823f6
4166dc3
b1c3581
1d67a01
f165587
513d585
991c3ce
400fc52
0bbc7cc
09b9492
13564ad
cd51c6e
08b1bab
b4313a0
36e7d26
d23413d
addc5ed
ce9d4a7
03742ff
55c0e47
e4ee1d3
e5a352b
caa2ed2
351760c
3f6f27c
b9e3e66
ba71127
ee6932e
2b945a0
ef0fa38
cbab111
0d32bbe
0f52185
ada0013
74647f2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider reserving the vector size then using
emplace_back
. And while you're at it, maybe usestd::for_each
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added
reserve()
. What's the advantage of usingstd::for_each
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None really, just following the general propensity of the cudf team to prefer algorithms over raw loops. I don't personally see a reason to change this and only suggested it since you'd be changing the code anyway..