Remove drop_nan from internal IndexedFrame._drop_na_rows.
#10140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
Python
galipremsagar
approved these changes
Jan 27, 2022
galipremsagar
added
the
5 - Ready to Merge
vyasr
approved these changes
Jan 27, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10140 +/- ##
================================================
+ Coverage 10.37% 10.43% +0.05%
================================================
Files 119 119
Lines 20149 20590 +441
================================================
+ Hits 2091 2148 +57
- Misses 18058 18442 +384
Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
drop_nanparameter from the internal APIIndexedFrame._drop_na_rows. Its behavior was unused internally in cudf (always set toTruein the public APIIndexedFrame.dropna). The behavior ofdrop_nan=Falsewas untested until 22.02 hotfix #10123, when an issue was found in gpu-bdb. However, that code can use the public APIdf.dropna(axis=0)instead. See rapidsai/gpu-bdb#228.This is marked as a non-breaking change because it only affects internal APIs.
Resolves #10125, follows up on #10123.