Change cudf::strings::find_multiple to return a lists column #10134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10134 +/- ##
================================================
+ Coverage 10.37% 10.48% +0.10%
================================================
Files 119 122 +3
Lines 20149 20493 +344
================================================
+ Hits 2091 2148 +57
- Misses 18058 18345 +287
Continue to review full report at Codecov.
|
davidwendt
added
3 - Ready for Review
robertmaynard
approved these changes
Jan 28, 2022
ttnghia
reviewed
Jan 28, 2022
ttnghia
approved these changes
Jan 28, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #10126
This changes the current
cudf::strings::find_multipleAPI to return a lists column instead of a flattened matrix as a column of integers. Each lists column size is equal to the size of the input strings and each row's size is equal to input targets column size.Making this a breaking change since it changes the result of a public libcudf API.