Remove the option to completely disable decimal128 columns in the ORC reader #10127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
vuule
added
improvement
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10127 +/- ##
================================================
+ Coverage 10.37% 10.43% +0.05%
================================================
Files 119 119
Lines 20149 20590 +441
================================================
+ Hits 2091 2148 +57
- Misses 18058 18442 +384
Continue to review full report at Codecov.
|
bdice
requested changes
Jan 26, 2022
ttnghia
approved these changes
Jan 26, 2022
bdice
approved these changes
Jan 26, 2022
galipremsagar
approved these changes
Jan 26, 2022
|
rerun tests |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option was put in place to prevent Python users of the read_orc API to read decimal columns as 128bit, since this type was not supported in Python at the time.
Now that decimal128 in supported in Python, this option can be removed.
The change in technically breaking, but it is very unlikely that anyone is using the API.