Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libcudacxx patch needed for nvcc 11.4 #10057

Conversation

robertmaynard
Copy link
Contributor

The libcudacxx.patch was required to fix issues with libcudacxx 1.6 and incorrect detection of the arm nvcc 11.4 compiler.

As we move to libcudacxx 1.7 this patch is not needed, and should be removed.

@robertmaynard robertmaynard added feature request New feature or request 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jan 14, 2022
@robertmaynard robertmaynard requested review from shwina and a team January 14, 2022 19:08
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #10057 (e843c1d) into branch-22.02 (967a333) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head e843c1d differs from pull request most recent head 13ee506. Consider uploading reports for the commit 13ee506 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02   #10057      +/-   ##
================================================
- Coverage         10.49%   10.36%   -0.13%     
================================================
  Files               119      119              
  Lines             20305    20628     +323     
================================================
+ Hits               2130     2139       +9     
- Misses            18175    18489     +314     
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.66% <0.00%> (-0.25%) ⬇️
python/dask_cudf/dask_cudf/core.py 70.85% <0.00%> (-0.17%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/scalar.py 0.00% <0.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e78f47a...13ee506. Read the comment docs.

@robertmaynard
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor

rerun tests

3 similar comments
@vyasr
Copy link
Contributor

vyasr commented Jan 20, 2022

rerun tests

@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar
Copy link
Contributor

@robertmaynard is this good to be merged?

@robertmaynard
Copy link
Contributor Author

@robertmaynard is this good to be merged?

Yes, just waiting on a green CI

@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 12a0f59 into rapidsai:branch-22.02 Jan 20, 2022
@robertmaynard robertmaynard deleted the fea/remove_libcudacxx_cuda11.4_patch branch January 20, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants