Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include <optional> in headers that use std::optional #10044

Merged
merged 7 commits into from
Jan 20, 2022
Merged

Include <optional> in headers that use std::optional #10044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
89a3694
Include <optional> in headers that use std::optional
robertmaynard Jan 13, 2022
8ef3fd2
Merge branch 'branch-22.02' into bug/include_optional_where_used
robertmaynard Jan 14, 2022
059d016
Merge branch 'branch-22.02' into bug/include_optional_where_used
robertmaynard Jan 18, 2022
770cb0c
include optional header where std::optional is used
robertmaynard Jan 18, 2022
719b6dc
Merge branch 'branch-22.02' into bug/include_optional_where_used
robertmaynard Jan 18, 2022
d2dffc0
Merge branch 'branch-22.02' into bug/include_optional_where_used
robertmaynard Jan 19, 2022
7c656a5
Merge branch 'branch-22.02' into bug/include_optional_where_used
robertmaynard Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/benchmarks/common/generate_benchmark_input.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2021, NVIDIA CORPORATION.
* Copyright (c) 2020-2022, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -31,6 +31,7 @@

#include <future>
#include <memory>
#include <optional>
#include <random>
#include <thread>
#include <vector>
Expand Down
2 changes: 2 additions & 0 deletions cpp/include/cudf/strings/repeat_strings.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
#include <cudf/scalar/scalar.hpp>
#include <cudf/strings/strings_column_view.hpp>

#include <optional>

namespace cudf {
namespace strings {
/**
Expand Down
2 changes: 2 additions & 0 deletions cpp/include/cudf/strings/replace_re.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
#include <cudf/strings/regex/flags.hpp>
#include <cudf/strings/strings_column_view.hpp>

#include <optional>

namespace cudf {
namespace strings {
/**
Expand Down
2 changes: 2 additions & 0 deletions cpp/src/io/utilities/trie.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

#include <cudf/utilities/span.hpp>

#include <optional>

namespace cudf {
namespace detail {
static constexpr char trie_terminating_character = '\n';
Expand Down