Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java bindings for mixed semi and anti joins #10040

Merged
merged 8 commits into from
Jan 25, 2022
Merged

Java bindings for mixed semi and anti joins #10040

merged 8 commits into from
Jan 25, 2022

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Jan 13, 2022

This depends on #9941 and #10037. Adds Java bindings for mixed left semi join and mixed left anti join.

@jlowe jlowe added feature request New feature or request 2 - In Progress Currently a work in progress Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Jan 13, 2022
@jlowe jlowe self-assigned this Jan 13, 2022
@jlowe jlowe requested a review from a team as a code owner January 13, 2022 19:34
@codecov
Copy link

codecov bot commented Jan 13, 2022 •
edited
Loading

Codecov Report

Merging #10040 (00eee6f) into branch-22.04 (e24fa8f) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10040      +/-   ##
================================================
+ Coverage         10.37%   10.42%   +0.04%     
================================================
  Files               119      119              
  Lines             20149    20607     +458     
================================================
+ Hits               2091     2148      +57     
- Misses            18058    18459     +401
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/orc.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/parquet.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/decimal.py 0.00% <0.00%> (ø)
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a552afb...00eee6f. Read the comment docs.

@jlowe jlowe mentioned this pull request Jan 13, 2022
Merged
@jlowe jlowe added 3 - Ready for Review Ready for review by team 5 - Merge After Dependencies and removed 2 - In Progress Currently a work in progress labels Jan 19, 2022
@jlowe jlowe marked this pull request as draft January 19, 2022 20:33
@jlowe
Copy link
Member Author

jlowe commented Jan 19, 2022

Converting this to a draft until #10037 has been merged to avoid inadvertent early merging since Java CI failures are a non-blocker.

@abellina abellina self-requested a review January 19, 2022 20:36
jbrennan333
jbrennan333 approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this looks good to me.

@jlowe jlowe changed the base branch from branch-22.02 to branch-22.04 January 21, 2022 15:54
@jlowe jlowe marked this pull request as ready for review January 25, 2022 15:27
@jlowe
Copy link
Member Author

jlowe commented Jan 25, 2022

#10037 has been merged, so this should be ready to go.

@jlowe jlowe added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 5 - Merge After Dependencies labels Jan 25, 2022
@jlowe
Copy link
Member Author

jlowe commented Jan 25, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 52a61b7 into rapidsai:branch-22.04 Jan 25, 2022
@jlowe jlowe deleted the jni-mixed-semi-join branch January 25, 2022 17:54
@mythrocks mythrocks mentioned this pull request Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrennan333 jbrennan333 jbrennan333 approved these changes

@tgravescs tgravescs tgravescs approved these changes

@abellina abellina abellina approved these changes

Assignees

@jlowe jlowe

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlowe @abellina @tgravescs @jbrennan333