Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timing chart for libcudf build metrics report page #10038

Merged
merged 23 commits into from
Jan 31, 2022
Merged

Add timing chart for libcudf build metrics report page #10038

merged 23 commits into from
Jan 31, 2022

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Jan 13, 2022 •
edited
Loading

Adds build time chart similar to ninjatracing output to the "Build Metrics Report" in a cudf build.

Other changes include

  • showing times in minutes, seconds, or milliseconds as appropriate
  • showing sizes in MB, KB, or bytes as appropriate
  • adding a 4th color (white) for compile times less than 1s
  • changed logic for identifying entries uniquely by hash instead of name (both in .ninja_log)

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 13, 2022
@davidwendt davidwendt self-assigned this Jan 13, 2022
@codecov
Copy link

codecov bot commented Jan 13, 2022 •
edited
Loading

Codecov Report

Merging #10038 (6e776d1) into branch-22.04 (e24fa8f) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10038      +/-   ##
================================================
+ Coverage         10.37%   10.43%   +0.05%     
================================================
  Files               119      119              
  Lines             20149    20594     +445     
================================================
+ Hits               2091     2148      +57     
- Misses            18058    18446     +388
Impacted Files Coverage Δ
python/cudf/cudf/errors.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd1c39...6e776d1. Read the comment docs.

@davidwendt
Copy link
Contributor Author

Example output of a nearly full build
https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-cpu-cuda-build/CUDA=11.5/7096/Build_20Metrics_20Report/

@github-actions github-actions bot added the gpuCI label Jan 19, 2022
@davidwendt davidwendt changed the base branch from branch-22.02 to branch-22.04 January 20, 2022 14:40
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jan 24, 2022
@davidwendt davidwendt marked this pull request as ready for review January 24, 2022 22:17
@davidwendt davidwendt requested review from a team as code owners January 24, 2022 22:17
@davidwendt davidwendt requested a review from vuule January 24, 2022 22:17
vuule
vuule approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one nit: would it be possible/preferrable to represent the time in minutes as minutes:seconds (or maybe always use seconds)? Seeing 1.975 minutes is odd, at least to me.

ajschmidt8
ajschmidt8 approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

karthikeyann
karthikeyann reviewed Jan 27, 2022
View reviewed changes
ci/cpu/build.sh Outdated Show resolved Hide resolved
karthikeyann
karthikeyann approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6e500d1 into rapidsai:branch-22.04 Jan 31, 2022
@davidwendt davidwendt deleted the build-time-chart branch January 31, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @karthikeyann @ajschmidt8 @vuule