Fix memory leaks in JNI native code. #10029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a couple of minor, host-side memory leaks in the JNI native code. The objects in question did not need to go on the heap. They have been switched to stack objects.
mythrocks
added
bug
jlowe
reviewed
Jan 12, 2022
jlowe
approved these changes
Jan 12, 2022
|
Thanks for the review, @jlowe. I'll merge this after CI passes. |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #10029 +/- ##
================================================
- Coverage 10.49% 10.41% -0.08%
================================================
Files 119 119
Lines 20305 20498 +193
================================================
+ Hits 2130 2134 +4
- Misses 18175 18364 +189
Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a couple of minor, host-side memory leaks
in the JNI native code. The objects in question did not need
to go on the heap. They have, in this commit, been switched to
stack objects.