Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JNI to use new arena mr constructor #10027

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Jan 12, 2022

And fix a failing test.

@rongou rongou added bug Something isn't working 3 - Ready for Review Ready for review by team tests Unit testing for project RMM ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Jan 12, 2022
@rongou rongou requested a review from jlowe January 12, 2022 19:06
@rongou rongou self-assigned this Jan 12, 2022
@rongou rongou requested a review from a team as a code owner January 12, 2022 19:06
@jlowe
Copy link
Member

jlowe commented Jan 12, 2022

@gpucibot merge

@jlowe jlowe added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround labels Jan 12, 2022
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #10027 (3b06f9f) into branch-22.02 (967a333) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 3b06f9f differs from pull request most recent head 4210c7a. Consider uploading reports for the commit 4210c7a to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02   #10027      +/-   ##
================================================
- Coverage         10.49%   10.41%   -0.08%     
================================================
  Files               119      119              
  Lines             20305    20495     +190     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18361     +186     
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 093b0ad...4210c7a. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 76f89db into rapidsai:branch-22.02 Jan 12, 2022
@rongou rongou deleted the update-arena branch January 21, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants