-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _from_column_like_self
factory
#10022
Add _from_column_like_self
factory
#10022
Conversation
…ent/_from_columns_like_self
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #10022 +/- ##
================================================
- Coverage 10.49% 10.37% -0.12%
================================================
Files 119 119
Lines 20305 20158 -147
================================================
- Hits 2130 2091 -39
+ Misses 18175 18067 -108
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like keeping this PR's scope narrow for now since it's targeting 22.02. We'll need to make a follow-up PR that looks through all of the classes inheriting from Frame
and substitutes this new factory everywhere that it could be used. I think there are a lot more places. Additionally, we'll probably find some places where _from_columns
is being called without a subsequent call to _apply_type_metadata
, so we should be able to fix some bugs by doing that scan.
Co-authored-by: Vyas Ramasubramani <[email protected]>
…id/cudf into improvement/_from_columns_like_self
rerun tests |
2 similar comments
rerun tests |
rerun tests |
rerun tests |
@gpucibot merge |
1 similar comment
@gpucibot merge |
Follow up to #9558
On a return trip from libcudf, it is a common pattern for cudf frame to apply its own metadata to the columns. This PR generalizes this procedure as a new factory function
_from_colums_like_self