Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CUDA_DEVICE_CALLABLE macro usage #10015

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

hyperbolic2346
Copy link
Contributor

CUDA_DEVICE_CALLABLE was deprecated immediately after merging 8444 which included some new calls that were missed.

@hyperbolic2346 hyperbolic2346 requested a review from a team as a code owner January 11, 2022 15:25
@github-actions github-actions bot added the Java Affects Java cuDF API. label Jan 11, 2022
@jlowe jlowe added bug Something isn't working non-breaking Non-breaking change labels Jan 11, 2022
@ttnghia ttnghia changed the title removing CUDA_DEVICE_CALLABLE macro usage Remove CUDA_DEVICE_CALLABLE macro usage Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #10015 (7102cd5) into branch-22.02 (967a333) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 7102cd5 differs from pull request most recent head 616b2f1. Consider uploading reports for the commit 616b2f1 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02   #10015      +/-   ##
================================================
- Coverage         10.49%   10.42%   -0.07%     
================================================
  Files               119      119              
  Lines             20305    20468     +163     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18334     +159     
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 951f630...616b2f1. Read the comment docs.

@jlowe
Copy link
Member

jlowe commented Jan 11, 2022

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] row_conversion.cu(155): error: identifier "CUDA_DEVICE_CALLABLE" is undefined in Java build
4 participants