Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom CUDA bindings previously provided by RMM with official CUDA Python bindings #10008

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Replace custom CUDA bindings previously provided by RMM with official CUDA Python bindings #10008

merged 3 commits into from
Jan 20, 2022

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Jan 10, 2022

This PR replaces custom CUDA bindings that are provided by RMM, with official CUDA Python bindings. This PR should be merged after the RMM PR rapidsai/rmm#930

@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 10, 2022
@shwina shwina marked this pull request as ready for review January 11, 2022 15:02
@shwina shwina requested a review from a team as a code owner January 11, 2022 15:02
@shwina shwina added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jan 11, 2022
brandon-b-miller
brandon-b-miller reviewed Jan 11, 2022
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending adding the dependency

vyasr
vyasr requested changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I grepped the code base and couldn't find any other uses of these APIs. We'll also need to update conda environments, conda recipes, and docker/package_versions.sh (optional). Since we don't put dependencies in our setup.[py|cfg] scripts I don't think we need to touch those.

@shwina shwina requested a review from a team as a code owner January 12, 2022 15:51
@github-actions github-actions bot added the conda label Jan 12, 2022
@vyasr
Copy link
Contributor

vyasr commented Jan 14, 2022

Still curious about docker/package_version.sh, can someone in @rapidsai/ops-codeowners confirm whether that needs an update as well?

@ajschmidt8
Copy link
Member

Still curious about docker/package_version.sh, can someone in @rapidsai/ops-codeowners confirm whether that needs an update as well?

That can be removed.

@galipremsagar
Copy link
Contributor

rerun tests

1 similar comment
@shwina
Copy link
Contributor Author

shwina commented Jan 19, 2022

rerun tests

@shwina shwina removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jan 19, 2022
@galipremsagar galipremsagar added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function 5 - Ready to Merge Testing and reviews complete, ready to merge labels Jan 19, 2022
bdice
bdice requested changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the outdated shim for CUDA 10 support. Also please fix the errant tab on line 81 (Maxwell ... 5.x) to spaces.

python/cudf/cudf/utils/gpu_utils.py Show resolved Hide resolved
@galipremsagar galipremsagar mentioned this pull request Jan 19, 2022
Merged
bdice
bdice approved these changes Jan 19, 2022
View reviewed changes
python/cudf/cudf/utils/gpu_utils.py Show resolved Hide resolved
@bdice bdice mentioned this pull request Jan 19, 2022
Closed
@robertmaynard robertmaynard mentioned this pull request Jan 19, 2022
Merged
@codecov
Copy link

codecov bot commented Jan 19, 2022 •
edited
Loading

Codecov Report

Merging #10008 (206535d) into branch-22.02 (967a333) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02   #10008      +/-   ##
================================================
- Coverage         10.49%   10.40%   -0.09%     
================================================
  Files               119      119              
  Lines             20305    20557     +252     
================================================
+ Hits               2130     2139       +9     
- Misses            18175    18418     +243
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.66% <0.00%> (-0.25%) ⬇️
python/dask_cudf/dask_cudf/core.py 70.85% <0.00%> (-0.17%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/scalar.py 0.00% <0.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd390a2...206535d. Read the comment docs.

@bdice bdice mentioned this pull request Jan 19, 2022
Merged
@codereport codereport mentioned this pull request Jan 19, 2022
Merged
7 tasks
@galipremsagar
Copy link
Contributor

rerun tests

1 similar comment
@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar
Copy link
Contributor

@gpucibot merge

@galipremsagar galipremsagar removed the request for review from marlenezw January 20, 2022 00:46
@rapids-bot rapids-bot bot merged commit f041034 into rapidsai:branch-22.02 Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller left review comments

@bdice bdice bdice approved these changes

@jjacobelli jjacobelli jjacobelli approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shwina @vyasr @ajschmidt8 @galipremsagar @bdice @jjacobelli @brandon-b-miller