Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add groupby.transform (only support for aggregations) #10005

Merged
merged 13 commits into from
Jan 20, 2022
Merged

Add groupby.transform (only support for aggregations) #10005

merged 13 commits into from
Jan 20, 2022

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Jan 10, 2022

Closes #4522

This PR adds support for doing groupby aggregations via the transform() API, where the result of the aggregation is broadcasted to the size of the group. Note that more general transformations are not supported at this time.

@shwina shwina requested a review from a team as a code owner January 10, 2022 15:19
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022 •
edited
Loading

Codecov Report

Merging #10005 (a560cbd) into branch-22.02 (967a333) will decrease coverage by 2.10%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02   #10005      +/-   ##
================================================
- Coverage         10.49%    8.38%   -2.11%     
================================================
  Files               119      119              
  Lines             20305    25498    +5193     
================================================
+ Hits               2130     2139       +9     
- Misses            18175    23359    +5184
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.66% <0.00%> (-0.25%) ⬇️
python/dask_cudf/dask_cudf/core.py 70.85% <0.00%> (-0.17%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/scalar.py 0.00% <0.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd390a2...a560cbd. Read the comment docs.

@shwina shwina added feature request New feature or request non-breaking Non-breaking change labels Jan 10, 2022
isVoid
isVoid approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shwina
Copy link
Contributor Author

shwina commented Jan 14, 2022

rerun tests

@shwina
Copy link
Contributor Author

shwina commented Jan 19, 2022

rerun tests

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jan 19, 2022
@galipremsagar
Copy link
Contributor

rerun tests

1 similar comment
@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e78f47a into rapidsai:branch-22.02 Jan 20, 2022
@galipremsagar galipremsagar removed the request for review from brandon-b-miller January 20, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Groupby transform functions
3 participants
@shwina @galipremsagar @isVoid