-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conda
recipes for custreamz
& cudf_kafka
#10003
Conversation
This PR updates the `conda` recipes for `custreamz` and `cudf_kafka`. The environment variable should be `PYTHON`, not `python` (case sensitive).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I knew this should be upper case. Not sure what I was thinking when I made it lower case? Thanks for submitting the PR
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #10003 +/- ##
==============================================
Coverage 10.41% 10.42%
==============================================
Files 119 119
Lines 20023 20471 +448
==============================================
+ Hits 2086 2134 +48
- Misses 17937 18337 +400
Continue to review full report at Codecov.
|
rerun tests |
From the chart on this page shown below, it look like the correct environment variable we should be using is |
@@ -34,7 +35,7 @@ requirements: | |||
run: | |||
- python {{ py_version }} | |||
- libcudf_kafka {{ version }} | |||
- python-confluent-kafka >=1.7.0,<1.8.0a0=py{{ py_version.replace('.', '') }}* | |||
- python-confluent-kafka >=1.7.0,<1.8.0a0=py{{ py_version_numeric }}* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakirkham, do you know if the =py{{ py_version_numeric }}*
suffix is extraneous here? conda
should solve for the correct Python version without it, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this PR for now. We can always remove this in the future if needed.
@gpucibot merge |
This PR updates the
conda
recipes forcustreamz
andcudf_kafka
. The environment variable should bePYTHON
, notpython
(case sensitive).