Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda recipes for custreamz & cudf_kafka #10003

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

ajschmidt8
Copy link
Member

This PR updates the conda recipes for custreamz and cudf_kafka. The environment variable should be PYTHON, not python (case sensitive).

This PR updates the `conda` recipes for `custreamz` and `cudf_kafka`. The environment variable should be `PYTHON`, not `python` (case sensitive).
@ajschmidt8 ajschmidt8 added bug Something isn't working non-breaking Non-breaking change labels Jan 7, 2022
@ajschmidt8 ajschmidt8 requested a review from jdye64 January 7, 2022 21:00
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner January 7, 2022 21:00
@github-actions github-actions bot added the conda label Jan 7, 2022
Copy link
Contributor

@jdye64 jdye64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I knew this should be upper case. Not sure what I was thinking when I made it lower case? Thanks for submitting the PR

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #10003 (4849e4a) into branch-22.02 (de8c0b8) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-22.02   #10003    +/-   ##
==============================================
  Coverage         10.41%   10.42%            
==============================================
  Files               119      119            
  Lines             20023    20471   +448     
==============================================
+ Hits               2086     2134    +48     
- Misses            17937    18337   +400     
Impacted Files Coverage Δ
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de8c0b8...4849e4a. Read the comment docs.

@galipremsagar
Copy link
Contributor

rerun tests

@ajschmidt8
Copy link
Member Author

Hmm. I'm seeing the error below in a lot of the build logs. I'll have to debug this locally in a bit.

image

@ajschmidt8
Copy link
Member Author

From the chart on this page shown below, it look like the correct environment variable we should be using is PY_VER instead of PYTHON.

image

@@ -34,7 +35,7 @@ requirements:
run:
- python {{ py_version }}
- libcudf_kafka {{ version }}
- python-confluent-kafka >=1.7.0,<1.8.0a0=py{{ py_version.replace('.', '') }}*
- python-confluent-kafka >=1.7.0,<1.8.0a0=py{{ py_version_numeric }}*
Copy link
Member Author

@ajschmidt8 ajschmidt8 Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakirkham, do you know if the =py{{ py_version_numeric }}* suffix is extraneous here? conda should solve for the correct Python version without it, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this PR for now. We can always remove this in the future if needed.

@ajschmidt8
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 951f630 into rapidsai:branch-22.02 Jan 11, 2022
@ajschmidt8 ajschmidt8 deleted the fix-recipes branch January 11, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants