Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] containsRe intermittently returns incorrect result for simple octal digit pattern #9946

Closed
andygrove opened this issue Dec 21, 2021 · 2 comments · Fixed by #9993
Closed

[BUG] containsRe intermittently returns incorrect result for simple octal digit pattern #9946

andygrove opened this issue Dec 21, 2021 · 2 comments · Fixed by #9993
Assignees
@davidwendt
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python)

Comments

@andygrove
Copy link
Contributor

Describe the bug
I am seeing inconsistent results when calling containsRe with the pattern \101 and the string A. On the first call, the method sometimes returns false and sometimes true. Subsequent calls always seem to return true.

Steps/Code to reproduce bug

Here is a JNI test that can be added to ColumnVectorTest.java.

  @Test
  void testContainsReOctalDigit() {
    String patternString = "\\101";
    try (ColumnVector testStrings = ColumnVector.fromStrings(null, "A", "B");
         ColumnVector res1 = testStrings.containsRe(patternString);
         ColumnVector res2 = testStrings.containsRe(patternString);
         ColumnVector expected = ColumnVector.fromBoxedBooleans(null, true, false)) {
        assertColumnsAreEqual(expected, res2);
        assertColumnsAreEqual(expected, res1);
    }
  }

The test sometimes fails on the second assertion (for the first result res1) but the assertion for res2 always passes. The assertions are intentionally in this order to demonstrate that the second call to containsRe succeeds and the first call sometimes fails.

The assertion failure message is:

[ERROR] testContainsReOctalDigit  Time elapsed: 0.003 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: Column unnamed Row 1 ==> expected: <1> but was: <0>

Expected behavior
The test should always pass.

Environment overview (please complete the following information)
Bare metal.

Environment details

Click here to see environment details
 **git***
 commit a4dc42d4c6b88b7f2da78d55934c01cb7479a6a1 (HEAD -> regexp-octal, rapidsai/branch-22.02, origin/branch-22.02, branch-22.02)
 Author: MithunR <[email protected]>
 Date:   Mon Dec 20 08:26:23 2021 -0800
 
 Implement `lists::index_of()` to find positions in list rows (#9510)
 
 Fixes #9164.
 
 ### Prelude
 `lists::contains()` (introduced in #7039) returns a `BOOL8` column, indicating whether the specified search_key(s) exist at all in each corresponding list row of an input LIST column. It does not return the actual position.
 
 ### `index_of()`
 This commit introduces `lists::index_of()`, to return the INT32 positions of the specified search_key(s) in a LIST column.
 
 The search keys may be searched for using either `FIND_FIRST` (which finds the position of the first occurrence), or `FIND_LAST` (which finds the last occurrence). Both column_view and scalar search keys are supported.
 
 As with `lists::contains()`, nested types are not supported as search keys in `lists::index_of()`.
 
 If the search_key cannot be found, that output row is set to `-1`. Additionally, the row `output[i]` is set to null if:
 1. The `search_key`(scalar) or `search_keys[i]`(column_view) is null.
 2. The list row `lists[i]` is null
 
 In all other cases, `output[i]` should contain a non-negative value.
 
 ### Semantic changes for `lists::contains()`
 This commit also modifies the semantics of `lists::contains()`: it will now return nulls only for the following cases:
 1. The `search_key`(scalar) or `search_keys[i]`(column_view) is null.
 2. The list row `lists[i]` is null
 
 In all other cases, a non-null bool is returned. Specifically `lists::contains()` no longer conforms to SQL semantics of returning `NULL` for list rows that don't contain the search key, while simultaneously containing nulls. In this case, `false` is returned.
 
 ### `lists::contains_null_elements()`
 A new function has been introduced to check if each list row contains null elements. The semantics are similar to `lists::contains()`, in that the column returned is BOOL8 typed:
 1. If even 1 element in a list row is null, the returned row is `true`.
 2. If no element is null, the returned row is `false`.
 3. If the list row is null, the returned row is `null`.
 4. If the list row is empty, the returned row is `false`.
 
 The current implementation is an inefficient placeholder, to be replaced once (#9588) is available. It is included here to reconstruct the SQL semantics dropped from `lists::contains()`.
 
 Authors:
 - MithunR (https://github.com/mythrocks)
 
 Approvers:
 - GALI PREM SAGAR (https://github.com/galipremsagar)
 - Jason Lowe (https://github.com/jlowe)
 - Mark Harris (https://github.com/harrism)
 - Conor Hoekstra (https://github.com/codereport)
 
 URL: https://github.com/rapidsai/cudf/pull/9510
 **git submodules***
 
 ***OS Information***
 DISTRIB_ID=Ubuntu
 DISTRIB_RELEASE=20.04
 DISTRIB_CODENAME=focal
 DISTRIB_DESCRIPTION="Ubuntu 20.04.3 LTS"
 NAME="Ubuntu"
 VERSION="20.04.3 LTS (Focal Fossa)"
 ID=ubuntu
 ID_LIKE=debian
 PRETTY_NAME="Ubuntu 20.04.3 LTS"
 VERSION_ID="20.04"
 HOME_URL="https://www.ubuntu.com/"
 SUPPORT_URL="https://help.ubuntu.com/"
 BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
 PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
 VERSION_CODENAME=focal
 UBUNTU_CODENAME=focal
 Linux ripper 5.11.0-43-generic #47~20.04.2-Ubuntu SMP Mon Dec 13 11:06:56 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
 
 ***GPU Information***
 Tue Dec 21 14:50:26 2021
 +-----------------------------------------------------------------------------+
 | NVIDIA-SMI 495.29.05    Driver Version: 495.29.05    CUDA Version: 11.5     |
 |-------------------------------+----------------------+----------------------+
 | GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
 | Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
 |                               |                      |               MIG M. |
 |===============================+======================+======================|
 |   0  NVIDIA GeForce ...  On   | 00000000:42:00.0  On |                  N/A |
 | 30%   50C    P8    24W / 320W |   1558MiB / 10014MiB |      0%      Default |
 |                               |                      |                  N/A |
 +-------------------------------+----------------------+----------------------+
 
 +-----------------------------------------------------------------------------+
 | Processes:                                                                  |
 |  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
 |        ID   ID                                                   Usage      |
 |=============================================================================|
 |    0   N/A  N/A      1666      G   /usr/lib/xorg/Xorg                102MiB |
 |    0   N/A  N/A      2733      G   /usr/lib/xorg/Xorg                626MiB |
 |    0   N/A  N/A      2930      G   /usr/bin/gnome-shell               98MiB |
 |    0   N/A  N/A      4852      G   ./jetbrains-toolbox                14MiB |
 |    0   N/A  N/A    287130      C   python                            515MiB |
 |    0   N/A  N/A    887858      G   ...690436.log --shared-files        4MiB |
 |    0   N/A  N/A   2373981      G   ...AAAAAAAAA= --shared-files       40MiB |
 |    0   N/A  N/A   3908527      G   /usr/lib/firefox/firefox          133MiB |
 |    0   N/A  N/A   3908834      G   /usr/lib/firefox/firefox            3MiB |
 +-----------------------------------------------------------------------------+
 
 ***CPU***
 Architecture:                    x86_64
 CPU op-mode(s):                  32-bit, 64-bit
 Byte Order:                      Little Endian
 Address sizes:                   43 bits physical, 48 bits virtual
 CPU(s):                          48
 On-line CPU(s) list:             0-47
 Thread(s) per core:              2
 Core(s) per socket:              24
 Socket(s):                       1
 NUMA node(s):                    4
 Vendor ID:                       AuthenticAMD
 CPU family:                      23
 Model:                           8
 Model name:                      AMD Ryzen Threadripper 2970WX 24-Core Processor
 Stepping:                        2
 Frequency boost:                 enabled
 CPU MHz:                         2200.000
 CPU max MHz:                     3000.0000
 CPU min MHz:                     2200.0000
 BogoMIPS:                        5987.77
 Virtualization:                  AMD-V
 L1d cache:                       768 KiB
 L1i cache:                       1.5 MiB
 L2 cache:                        12 MiB
 L3 cache:                        64 MiB
 NUMA node0 CPU(s):               0-5,24-29
 NUMA node1 CPU(s):               12-17,36-41
 NUMA node2 CPU(s):               6-11,30-35
 NUMA node3 CPU(s):               18-23,42-47
 Vulnerability Itlb multihit:     Not affected
 Vulnerability L1tf:              Not affected
 Vulnerability Mds:               Not affected
 Vulnerability Meltdown:          Not affected
 Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
 Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
 Vulnerability Spectre v2:        Mitigation; Full AMD retpoline, IBPB conditional, STIBP disabled, RSB filling
 Vulnerability Srbds:             Not affected
 Vulnerability Tsx async abort:   Not affected
 Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid amd_dcm aperfmperf pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb hw_pstate sme ssbd sev ibpb vmmcall sev_es fsgsbase bmi1 avx2 smep bmi2 rdseed adx smap clflushopt sha_ni xsaveopt xsavec xgetbv1 xsaves clzero irperf xsaveerptr arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif overflow_recov succor smca
 
 ***CMake***
 /home/andy/miniconda3/envs/cudf_dev/bin/cmake
 cmake version 3.21.3
 
 CMake suite maintained and supported by Kitware (kitware.com/cmake).
 
 ***g++***
 /usr/bin/g++
 g++ (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
 Copyright (C) 2019 Free Software Foundation, Inc.
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 
 
 ***nvcc***
 /usr/local/cuda/bin/nvcc
 nvcc: NVIDIA (R) Cuda compiler driver
 Copyright (c) 2005-2021 NVIDIA Corporation
 Built on Thu_Nov_18_09:45:30_PST_2021
 Cuda compilation tools, release 11.5, V11.5.119
 Build cuda_11.5.r11.5/compiler.30672275_0
 
 ***Python***
 /home/andy/miniconda3/envs/cudf_dev/bin/python
 Python 3.8.12
 
 ***Environment Variables***
 PATH                            : /home/andy/miniconda3/envs/cudf_dev/bin:/home/andy/miniconda3/condabin:/home/andy/.cargo/bin:/home/andy/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/opt/apache-maven-3.8.2/bin:mvnd-0.5.2-linux-amd64/bin:/usr/local/cuda/bin
 LD_LIBRARY_PATH                 : :/usr/local/cuda/targets/x86_64-linux/lib/:/usr/local/cuda/lib64
 NUMBAPRO_NVVM                   :
 NUMBAPRO_LIBDEVICE              :
 CONDA_PREFIX                    : /home/andy/miniconda3/envs/cudf_dev
 PYTHON_PATH                     :
 
 ***conda packages***
 /home/andy/miniconda3/condabin/conda
 # packages in environment at /home/andy/miniconda3/envs/cudf_dev:
 #
 # Name                    Version                   Build  Channel
 _libgcc_mutex             0.1                 conda_forge    conda-forge
 _openmp_mutex             4.5                      1_llvm    conda-forge
 abseil-cpp                20210324.2           h9c3ff4c_0    conda-forge
 alabaster                 0.7.12                     py_0    conda-forge
 appdirs                   1.4.4              pyh9f0ad1d_0    conda-forge
 argon2-cffi               21.1.0           py38h497a2fe_2    conda-forge
 arrow-cpp                 5.0.0           py38hab3e76a_21_cuda    conda-forge
 arrow-cpp-proc            3.0.0                      cuda    conda-forge
 async_generator           1.10                       py_0    conda-forge
 attrs                     21.2.0             pyhd8ed1ab_0    conda-forge
 aws-c-cal                 0.5.11               h95a6274_0    conda-forge
 aws-c-common              0.6.2                h7f98852_0    conda-forge
 aws-c-event-stream        0.2.7               h3541f99_13    conda-forge
 aws-c-io                  0.10.5               hfb6a706_0    conda-forge
 aws-checksums             0.1.11               ha31a3da_7    conda-forge
 aws-sdk-cpp               1.8.186              hb4091e7_3    conda-forge
 babel                     2.9.1              pyh44b312d_0    conda-forge
 backcall                  0.2.0              pyh9f0ad1d_0    conda-forge
 backports                 1.0                        py_2    conda-forge
 backports-zoneinfo        0.2.1                    pypi_0    pypi
 backports.functools_lru_cache 1.6.4              pyhd8ed1ab_0    conda-forge
 beautifulsoup4            4.10.0             pyha770c72_0    conda-forge
 binutils_impl_linux-64    2.36.1               h193b22a_2    conda-forge
 black                     19.10b0                    py_4    conda-forge
 bleach                    4.1.0              pyhd8ed1ab_0    conda-forge
 bokeh                     2.4.2            py38h578d9bd_0    conda-forge
 brotlipy                  0.7.0           py38h497a2fe_1003    conda-forge
 bzip2                     1.0.8                h7f98852_4    conda-forge
 c-ares                    1.18.1               h7f98852_0    conda-forge
 ca-certificates           2021.10.8            ha878542_0    conda-forge
 cachetools                4.2.4              pyhd8ed1ab_0    conda-forge
 certifi                   2021.10.8        py38h578d9bd_1    conda-forge
 cffi                      1.15.0           py38h3931269_0    conda-forge
 cfgv                      3.3.1              pyhd8ed1ab_0    conda-forge
 charset-normalizer        2.0.9              pyhd8ed1ab_0    conda-forge
 clang                     11.1.0               ha770c72_1    conda-forge
 clang-11                  11.1.0          default_ha53f305_1    conda-forge
 clang-tools               11.1.0          default_ha53f305_1    conda-forge
 clangxx                   11.1.0          default_ha53f305_1    conda-forge
 click                     8.0.3            py38h578d9bd_1    conda-forge
 cloudpickle               2.0.0              pyhd8ed1ab_0    conda-forge
 cmake                     3.21.3               h8897547_0    conda-forge
 cmake_setuptools          0.1.3                      py_0    rapidsai
 colorama                  0.4.4              pyh9f0ad1d_0    conda-forge
 commonmark                0.9.1                      py_0    conda-forge
 cryptography              36.0.1           py38h3e25421_0    conda-forge
 cudatoolkit               11.5.0               h36ae40a_9    nvidia
 cupy                      9.6.0            py38h177b0fd_0    conda-forge
 cyrus-sasl                2.1.27               h230043b_5    conda-forge
 cython                    0.29.26          py38h709712a_0    conda-forge
 cytoolz                   0.11.2           py38h497a2fe_1    conda-forge
 dask                      2021.12.0+12.g124ae53f          pypi_0    pypi
 dataclasses               0.8                pyhc8e2a94_3    conda-forge
 debugpy                   1.5.1            py38h709712a_0    conda-forge
 decorator                 5.1.0              pyhd8ed1ab_0    conda-forge
 defusedxml                0.7.1              pyhd8ed1ab_0    conda-forge
 distlib                   0.3.4              pyhd8ed1ab_0    conda-forge
 distributed               2021.12.0+19.gfde910a5          pypi_0    pypi
 dlpack                    0.5                  h9c3ff4c_0    conda-forge
 docutils                  0.17.1           py38h578d9bd_1    conda-forge
 double-conversion         3.1.6                h9c3ff4c_0    conda-forge
 editdistance-s            1.0.0            py38h1fd1430_2    conda-forge
 entrypoints               0.3             pyhd8ed1ab_1003    conda-forge
 execnet                   1.9.0              pyhd8ed1ab_0    conda-forge
 expat                     2.4.1                h9c3ff4c_0    conda-forge
 fastavro                  1.4.7            py38h497a2fe_1    conda-forge
 fastrlock                 0.8              py38h709712a_1    conda-forge
 filelock                  3.4.0              pyhd8ed1ab_0    conda-forge
 flake8                    3.8.3                      py_1    conda-forge
 freetype                  2.10.4               h0708190_1    conda-forge
 fsspec                    2021.11.1          pyhd8ed1ab_0    conda-forge
 future                    0.18.2           py38h578d9bd_4    conda-forge
 gcc_impl_linux-64         11.2.0              h82a94d6_11    conda-forge
 gettext                   0.19.8.1          h73d1719_1008    conda-forge
 gflags                    2.2.2             he1b5a44_1004    conda-forge
 glog                      0.5.0                h48cff8f_0    conda-forge
 gmp                       6.2.1                h58526e2_0    conda-forge
 grpc-cpp                  1.42.0               ha1441d3_1    conda-forge
 heapdict                  1.0.1                      py_0    conda-forge
 huggingface_hub           0.2.1              pyhd8ed1ab_0    conda-forge
 hypothesis                6.31.6             pyhd8ed1ab_0    conda-forge
 identify                  2.3.7              pyhd8ed1ab_0    conda-forge
 idna                      3.1                pyhd3deb0d_0    conda-forge
 imagesize                 1.3.0              pyhd8ed1ab_0    conda-forge
 importlib-metadata        4.10.0           py38h578d9bd_0    conda-forge
 importlib_metadata        4.10.0               hd8ed1ab_0    conda-forge
 importlib_resources       5.4.0              pyhd8ed1ab_0    conda-forge
 iniconfig                 1.1.1              pyh9f0ad1d_0    conda-forge
 ipykernel                 6.6.0            py38he5a9106_0    conda-forge
 ipython                   7.30.1           py38h578d9bd_0    conda-forge
 ipython_genutils          0.2.0                      py_1    conda-forge
 isort                     5.6.4                      py_0    conda-forge
 jbig                      2.1               h7f98852_2003    conda-forge
 jedi                      0.18.1           py38h578d9bd_0    conda-forge
 jinja2                    3.0.3              pyhd8ed1ab_0    conda-forge
 joblib                    1.1.0              pyhd8ed1ab_0    conda-forge
 jpeg                      9d                   h36c2ea0_0    conda-forge
 jsonschema                4.3.1              pyhd8ed1ab_0    conda-forge
 jupyter_client            7.1.0              pyhd8ed1ab_0    conda-forge
 jupyter_core              4.9.1            py38h578d9bd_1    conda-forge
 jupyterlab_pygments       0.1.2              pyh9f0ad1d_0    conda-forge
 kernel-headers_linux-64   2.6.32              he073ed8_15    conda-forge
 krb5                      1.19.2               hcc1bbae_3    conda-forge
 lcms2                     2.12                 hddcbb42_0    conda-forge
 ld_impl_linux-64          2.36.1               hea4e1c9_2    conda-forge
 lerc                      3.0                  h9c3ff4c_0    conda-forge
 libblas                   3.9.0                     8_mkl    conda-forge
 libbrotlicommon           1.0.9                h7f98852_6    conda-forge
 libbrotlidec              1.0.9                h7f98852_6    conda-forge
 libbrotlienc              1.0.9                h7f98852_6    conda-forge
 libcblas                  3.9.0                     8_mkl    conda-forge
 libclang-cpp11.1          11.1.0          default_ha53f305_1    conda-forge
 libcurl                   7.80.0               h2574ce0_0    conda-forge
 libdeflate                1.8                  h7f98852_0    conda-forge
 libedit                   3.1.20191231         he28a2e2_2    conda-forge
 libev                     4.33                 h516909a_1    conda-forge
 libevent                  2.1.10               h9b69904_4    conda-forge
 libffi                    3.4.2                h7f98852_5    conda-forge
 libgcc-devel_linux-64     11.2.0              h0952999_11    conda-forge
 libgcc-ng                 11.2.0              h1d223b6_11    conda-forge
 libgcrypt                 1.9.4                h7f98852_0    conda-forge
 libgomp                   11.2.0              h1d223b6_11    conda-forge
 libgpg-error              1.42                 h9c3ff4c_0    conda-forge
 libgsasl                  1.10.0               h5b4c23d_0    conda-forge
 liblapack                 3.9.0                     8_mkl    conda-forge
 libllvm11                 11.1.0               hf817b99_2    conda-forge
 libnghttp2                1.43.0               h812cca2_1    conda-forge
 libnsl                    2.0.0                h7f98852_0    conda-forge
 libntlm                   1.4               h7f98852_1002    conda-forge
 libpng                    1.6.37               h21135ba_2    conda-forge
 libprotobuf               3.19.1               h780b84a_0    conda-forge
 librdkafka                1.7.0                hc49e61c_0    conda-forge
 librmm                    22.02.00a211220 cuda11_g846d638_23    rapidsai-nightly
 libsanitizer              11.2.0              he4da1e4_11    conda-forge
 libsodium                 1.0.18               h36c2ea0_1    conda-forge
 libssh2                   1.10.0               ha56f1ee_2    conda-forge
 libstdcxx-ng              11.2.0              he4da1e4_11    conda-forge
 libthrift                 0.15.0               he6d91bd_1    conda-forge
 libtiff                   4.3.0                h6f004c6_2    conda-forge
 libutf8proc               2.7.0                h7f98852_0    conda-forge
 libuv                     1.42.0               h7f98852_0    conda-forge
 libwebp-base              1.2.1                h7f98852_0    conda-forge
 libzlib                   1.2.11            h36c2ea0_1013    conda-forge
 llvm-openmp               12.0.1               h4bd325d_1    conda-forge
 llvmlite                  0.37.0           py38h4630a5e_1    conda-forge
 locket                    0.2.0                      py_2    conda-forge
 lz4-c                     1.9.3                h9c3ff4c_1    conda-forge
 markdown                  3.3.6              pyhd8ed1ab_0    conda-forge
 markupsafe                2.0.1            py38h497a2fe_1    conda-forge
 matplotlib-inline         0.1.3              pyhd8ed1ab_0    conda-forge
 mccabe                    0.6.1                      py_1    conda-forge
 mimesis                   4.0.0              pyh9f0ad1d_0    conda-forge
 mistune                   0.8.4           py38h497a2fe_1005    conda-forge
 mkl                       2020.4             h726a3e6_304    conda-forge
 more-itertools            8.12.0             pyhd8ed1ab_0    conda-forge
 msgpack-python            1.0.3            py38h1fd1430_0    conda-forge
 mypy                      0.782                      py_0    conda-forge
 mypy_extensions           0.4.3            py38h578d9bd_4    conda-forge
 nbclient                  0.5.9              pyhd8ed1ab_0    conda-forge
 nbconvert                 6.3.0            py38h578d9bd_1    conda-forge
 nbformat                  5.1.3              pyhd8ed1ab_0    conda-forge
 nbsphinx                  0.8.7              pyhd8ed1ab_0    conda-forge
 ncurses                   6.2                  h58526e2_4    conda-forge
 nest-asyncio              1.5.4              pyhd8ed1ab_0    conda-forge
 ninja                     1.10.2               h4bd325d_1    conda-forge
 nodeenv                   1.6.0              pyhd8ed1ab_0    conda-forge
 notebook                  6.4.6              pyha770c72_0    conda-forge
 numba                     0.54.1           py38h4bf6c61_0    conda-forge
 numpy                     1.20.3           py38h9894fe3_1    conda-forge
 numpydoc                  1.1.0                      py_1    conda-forge
 nvtx                      0.2.3            py38h497a2fe_1    conda-forge
 olefile                   0.46               pyh9f0ad1d_1    conda-forge
 openjpeg                  2.4.0                hb52868f_1    conda-forge
 openssl                   1.1.1l               h7f98852_0    conda-forge
 orc                       1.7.1                h1be678f_1    conda-forge
 packaging                 21.3               pyhd8ed1ab_0    conda-forge
 pandas                    1.3.5            py38h43a58ef_0    conda-forge
 pandoc                    1.19.2                        0    conda-forge
 pandocfilters             1.5.0              pyhd8ed1ab_0    conda-forge
 parquet-cpp               1.5.1                         2    conda-forge
 parso                     0.8.3              pyhd8ed1ab_0    conda-forge
 partd                     1.2.0              pyhd8ed1ab_0    conda-forge
 pathspec                  0.9.0              pyhd8ed1ab_0    conda-forge
 pexpect                   4.8.0              pyh9f0ad1d_2    conda-forge
 pickleshare               0.7.5                   py_1003    conda-forge
 pillow                    8.4.0            py38h8e6f84c_0    conda-forge
 pip                       21.3.1             pyhd8ed1ab_0    conda-forge
 pluggy                    1.0.0            py38h578d9bd_2    conda-forge
 pre-commit                2.16.0           py38h578d9bd_0    conda-forge
 prometheus_client         0.12.0             pyhd8ed1ab_0    conda-forge
 prompt-toolkit            3.0.24             pyha770c72_0    conda-forge
 protobuf                  3.19.1           py38h709712a_1    conda-forge
 psutil                    5.8.0            py38h497a2fe_2    conda-forge
 ptxcompiler               0.2.0            py38hb739d79_0    rapidsai
 ptyprocess                0.7.0              pyhd3deb0d_0    conda-forge
 py                        1.11.0             pyh6c4a22f_0    conda-forge
 py-cpuinfo                8.0.0              pyhd8ed1ab_0    conda-forge
 pyarrow                   5.0.0           py38ha746e9d_21_cuda    conda-forge
 pycodestyle               2.6.0              pyh9f0ad1d_0    conda-forge
 pycparser                 2.21               pyhd8ed1ab_0    conda-forge
 pydata-sphinx-theme       0.7.2              pyhd8ed1ab_0    conda-forge
 pydocstyle                6.1.1              pyhd8ed1ab_0    conda-forge
 pyflakes                  2.2.0              pyh9f0ad1d_0    conda-forge
 pygments                  2.10.0             pyhd8ed1ab_0    conda-forge
 pyopenssl                 21.0.0             pyhd8ed1ab_0    conda-forge
 pyorc                     0.5.0                    pypi_0    pypi
 pyparsing                 3.0.6              pyhd8ed1ab_0    conda-forge
 pyrsistent                0.18.0           py38h497a2fe_0    conda-forge
 pysocks                   1.7.1            py38h578d9bd_4    conda-forge
 pytest                    6.2.5            py38h578d9bd_1    conda-forge
 pytest-benchmark          3.4.1              pyhd8ed1ab_0    conda-forge
 pytest-forked             1.4.0              pyhd8ed1ab_0    conda-forge
 pytest-xdist              2.5.0              pyhd8ed1ab_0    conda-forge
 python                    3.8.12          hb7a2778_2_cpython    conda-forge
 python-confluent-kafka    1.7.0            py38h497a2fe_2    conda-forge
 python-dateutil           2.8.2              pyhd8ed1ab_0    conda-forge
 python-snappy             0.6.0            py38h49bdff1_1    conda-forge
 python_abi                3.8                      2_cp38    conda-forge
 pytorch                   1.7.1           cpu_py38h36eccb8_2    conda-forge
 pytz                      2021.3             pyhd8ed1ab_0    conda-forge
 pyyaml                    6.0              py38h497a2fe_3    conda-forge
 pyzmq                     22.3.0           py38h2035c66_1    conda-forge
 rapidjson                 1.1.0             he1b5a44_1002    conda-forge
 re2                       2021.11.01           h9c3ff4c_0    conda-forge
 readline                  8.1                  h46c0cb4_0    conda-forge
 recommonmark              0.7.1              pyhd8ed1ab_0    conda-forge
 regex                     2021.11.10       py38h497a2fe_0    conda-forge
 requests                  2.26.0             pyhd8ed1ab_1    conda-forge
 rhash                     1.4.1                h7f98852_0    conda-forge
 rmm                       22.02.00a211219 cuda11_py38_g846d638_23_has_cma    rapidsai-nightly
 s2n                       1.0.10               h9b69904_0    conda-forge
 sacremoses                0.0.46             pyhd8ed1ab_0    conda-forge
 send2trash                1.8.0              pyhd8ed1ab_0    conda-forge
 setuptools                59.6.0           py38h578d9bd_0    conda-forge
 six                       1.16.0             pyh6c4a22f_0    conda-forge
 snappy                    1.1.8                he1b5a44_3    conda-forge
 snowballstemmer           2.2.0              pyhd8ed1ab_0    conda-forge
 sortedcontainers          2.4.0              pyhd8ed1ab_0    conda-forge
 soupsieve                 2.3.1              pyhd8ed1ab_0    conda-forge
 spdlog                    1.8.5                h4bd325d_0    conda-forge
 sphinx                    4.3.2              pyh6c4a22f_0    conda-forge
 sphinx-copybutton         0.4.0              pyhd8ed1ab_0    conda-forge
 sphinx-markdown-tables    0.0.15             pyhd3deb0d_0    conda-forge
 sphinxcontrib-applehelp   1.0.2                      py_0    conda-forge
 sphinxcontrib-devhelp     1.0.2                      py_0    conda-forge
 sphinxcontrib-htmlhelp    2.0.0              pyhd8ed1ab_0    conda-forge
 sphinxcontrib-jsmath      1.0.1                      py_0    conda-forge
 sphinxcontrib-qthelp      1.0.3                      py_0    conda-forge
 sphinxcontrib-serializinghtml 1.1.5              pyhd8ed1ab_1    conda-forge
 sphinxcontrib-websupport  1.2.4              pyhd8ed1ab_1    conda-forge
 sqlite                    3.37.0               h9cd32fc_0    conda-forge
 streamz                   0.6.3              pyh6c4a22f_0    conda-forge
 sysroot_linux-64          2.12                he073ed8_15    conda-forge
 tblib                     1.7.0              pyhd8ed1ab_0    conda-forge
 terminado                 0.12.1           py38h578d9bd_1    conda-forge
 testpath                  0.5.0              pyhd8ed1ab_0    conda-forge
 tk                        8.6.11               h27826a3_1    conda-forge
 tokenizers                0.10.3           py38hb63a372_1    conda-forge
 toml                      0.10.2             pyhd8ed1ab_0    conda-forge
 toolz                     0.11.2             pyhd8ed1ab_0    conda-forge
 tornado                   6.1              py38h497a2fe_2    conda-forge
 tqdm                      4.62.3             pyhd8ed1ab_0    conda-forge
 traitlets                 5.1.1              pyhd8ed1ab_0    conda-forge
 transformers              4.10.3             pyhd8ed1ab_0    conda-forge
 typed-ast                 1.4.3            py38h497a2fe_1    conda-forge
 typing-extensions         4.0.1                hd8ed1ab_0    conda-forge
 typing_extensions         4.0.1              pyha770c72_0    conda-forge
 urllib3                   1.26.7             pyhd8ed1ab_0    conda-forge
 virtualenv                20.4.7           py38h578d9bd_1    conda-forge
 wcwidth                   0.2.5              pyh9f0ad1d_2    conda-forge
 webencodings              0.5.1                      py_1    conda-forge
 wheel                     0.37.0             pyhd8ed1ab_1    conda-forge
 xz                        5.2.5                h516909a_1    conda-forge
 yaml                      0.2.5                h516909a_0    conda-forge
 zeromq                    4.3.4                h9c3ff4c_1    conda-forge
 zict                      2.0.0                      py_0    conda-forge
 zipp                      3.6.0              pyhd8ed1ab_0    conda-forge
 zlib                      1.2.11            h36c2ea0_1013    conda-forge
 zstd                      1.5.0                ha95c52a_0    conda-forge

Additional context
None
@andygrove andygrove added bug Something isn't working Needs Triage Need team to review and classify labels Dec 21, 2021
@andygrove andygrove mentioned this issue Dec 21, 2021
Closed
@davidwendt davidwendt self-assigned this Dec 22, 2021
@davidwendt
Copy link
Contributor

I'm not able to recreate this error in libcudf.
Does this only happen calling through JNI?

@andygrove
Copy link
Contributor Author

I have only seen this via JNI, but that is also the only way I have tested so far. I will try and reproduce in libcudf.

@davidwendt davidwendt added libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) labels Jan 6, 2022
@davidwendt davidwendt mentioned this issue Jan 7, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Jan 14, 2022
@davidwendt
Fix octal pattern matching in regex string (#9993)
ce31d7d 
Closes #9946 

Fixes decoding logic in regex pattern compile step to consume only up to the last octal character. The original logic was incorrectly discarding the next pattern character. And if the octal characters were specified at the end of the pattern invalid bytes were read passed the end of the pattern. This is what caused the intermittent failure since sometimes the invalid bytes were 0 which masked the issue.

This PR also includes tests for octal patterns in various positions in the regex pattern.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Conor Hoekstra (https://github.com/codereport)
  - Mike Wilson (https://github.com/hyperbolic2346)
  - Nghia Truong (https://github.com/ttnghia)

URL: #9993
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwendt davidwendt

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix octal pattern matching in regex string davidwendt/cudf
3 participants
@andygrove @bdice @davidwendt