Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decimal128 tests to CSV/JSON #9791

Closed
2 of 3 tasks
vuule opened this issue Nov 29, 2021 · 2 comments · Fixed by #12229
Closed
2 of 3 tasks

Add decimal128 tests to CSV/JSON #9791

vuule opened this issue Nov 29, 2021 · 2 comments · Fixed by #12229
Assignees
@vuule
Labels
cuIO cuIO issue tests Unit testing for project
Milestone
Decimal data type...

Comments

@vuule
Copy link
Contributor

vuule commented Nov 29, 2021 •
edited
Loading

  • CSV reader
  • CSV writer
  • JSON reader
@vuule vuule added tests Unit testing for project cuIO cuIO issue labels Nov 29, 2021
@beckernick beckernick added this to the IO Data Type Expansion milestone Dec 16, 2021
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@vuule vuule mentioned this issue Nov 22, 2022
Merged
3 tasks
@vuule vuule self-assigned this Nov 22, 2022
rapids-bot bot pushed a commit that referenced this issue Dec 1, 2022
@vuule
Cover parsing to decimal types in read_json tests (#12229)
ff3b643 
Closes #9791

Adds `read_json` tests for decimal types. 
Tests are equivalent to existing `read_csv` tests for decimal types.
Tests invoke both JSON parsers.

Authors:
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - MithunR (https://github.com/mythrocks)

URL: #12229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vuule vuule

Labels
cuIO cuIO issue tests Unit testing for project
Projects
None yet
Milestone
Decimal data type and operations
Development

Successfully merging a pull request may close this issue.

Cover parsing to decimal types in read_json tests vuule/cudf
3 participants
@beckernick @GregoryKimball @vuule