Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ORC writing failed when table is empty #9783

Closed
sperlingxx opened this issue Nov 26, 2021 · 2 comments · Fixed by #9808
Closed

[BUG] ORC writing failed when table is empty #9783

sperlingxx opened this issue Nov 26, 2021 · 2 comments · Fixed by #9808
Assignees
@vuule
Labels
bug Something isn't working cuIO cuIO issue

Comments

@sperlingxx
Copy link
Contributor

Describe the bug
When writing an empty table, whose number of rows is 0, via cuDF ORC writer, it will throw a CUDA exception: for_each: failed to synchronize: cudaErrorInvalidConfiguration: invalid configuration argument.
If there exists empty string columns, the build_dictionaries method inside writer::impl::write will lead to a segmentation fault.

Steps/Code to reproduce bug
Writes an empty table through cudf::io::orc_chunked_writer.
@sperlingxx sperlingxx added bug Something isn't working Needs Triage Need team to review and classify labels Nov 26, 2021
@vuule vuule self-assigned this Nov 27, 2021
@vuule vuule added cuIO cuIO issue and removed Needs Triage Need team to review and classify labels Nov 27, 2021
@sperlingxx sperlingxx mentioned this issue Nov 29, 2021
Closed
@vuule
Copy link
Contributor

vuule commented Nov 30, 2021

Got local repro.
Looks like the issue is specific to writing files with Snappy compression.
Working on a fix.

@vuule vuule mentioned this issue Dec 1, 2021
Merged
@vuule
Copy link
Contributor

vuule commented Dec 1, 2021

Implemented the fix in #9808, will add more tests tomorrow and open for review.

@rapids-bot rapids-bot bot closed this as completed in #9808 Dec 2, 2021
rapids-bot bot pushed a commit that referenced this issue Dec 2, 2021
@vuule
Fix ORC writer crash with empty input columns (#9808)
b848dd5 
Fixes #9783

Skip some parts of writing when the input table was zero rows.
Add is_empty to `hostdevice_2dvector`.
Add Python test with empty columns.

Authors:
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Devavret Makkar (https://github.com/devavret)
  - Conor Hoekstra (https://github.com/codereport)

URL: #9808
@sperlingxx sperlingxx mentioned this issue Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vuule vuule

Labels
bug Something isn't working cuIO cuIO issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ORC writer crash with empty input columns vuule/cudf
2 participants
@sperlingxx @vuule