Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Java bindings for drop_duplicates #9115

Closed
jlowe opened this issue Aug 25, 2021 · 2 comments · Fixed by #9841
Closed

[FEA] Java bindings for drop_duplicates #9115

jlowe opened this issue Aug 25, 2021 · 2 comments · Fixed by #9841
Assignees
@ttnghia
Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS

Comments

@jlowe
Copy link
Member

jlowe commented Aug 25, 2021

Is your feature request related to a problem? Please describe.
As part of implementing batched full joins in Spark, we need the ability to concatenate join gather maps together and remove any duplicate entries. libcudf has a drop_duplicates function but this has not been exposed in the Java APIs.

Describe the solution you'd like
The cudf Java bindings should add a dropDuplicates method to Table with the corresponding options for what to keep, null ordering, and null equality.
@jlowe jlowe added feature request New feature or request Needs Triage Need team to review and classify Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS labels Aug 25, 2021
This was referenced Aug 25, 2021
Closed
Open
@beckernick beckernick removed the Needs Triage Need team to review and classify label Aug 25, 2021
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@jlowe
Copy link
Member Author

jlowe commented Nov 15, 2021

Still desired

@ttnghia ttnghia self-assigned this Dec 3, 2021
@ttnghia ttnghia mentioned this issue Dec 3, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #9841 Dec 3, 2021
rapids-bot bot pushed a commit that referenced this issue Dec 3, 2021
@ttnghia
Add JNI for cudf::drop_duplicates (#9841)
fdd9bb0 
This adds Java binding for `cudf::drop_duplicates`.

Note that when choosing which duplicate element to keep, only `KEEP_FIRST` or `KEEP_LAST` option can be selected. In other words, this does not support `KEEP_NONE` to remove all duplicate elements.

Closes #9115.

Authors:
  - Nghia Truong (https://github.com/ttnghia)

Approvers:
  - Jason Lowe (https://github.com/jlowe)

URL: #9841
@mythrocks mythrocks mentioned this issue Mar 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttnghia ttnghia

Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add JNI for cudf::drop_duplicates ttnghia/cudf
3 participants
@jlowe @ttnghia @beckernick