-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] row_bit_count produces Illegal memory acces on some data sets #8938
Comments
revans2
added
bug
Something isn't working
Needs Triage
Need team to review and classify
labels
Aug 3, 2021
Here's the result from
|
|
mythrocks
added a commit
to mythrocks/cudf
that referenced
this issue
Aug 19, 2021
For input with a number of rows exceeding `max_block_size`, `row_bit_count()` currently reaches past the bounds of its shared-memory allocation, causing illegal memory access errors like in (cudf/issues/8938)[rapidsai#8938]. This commit corrects the calculation of the branch stack's base address, and adds a test for this case.
rapids-bot bot
pushed a commit
that referenced
this issue
Aug 23, 2021
Fixes #8938. For input with a number of rows exceeding `max_block_size`, `row_bit_count()` currently reaches past the bounds of its shared-memory allocation, causing illegal memory access errors like in [cudf/issues/8938](#8938). This commit corrects the calculation of the branch stack's base address, and adds a test for this case. Authors: - MithunR (https://github.com/mythrocks) Approvers: - https://github.com/nvdbaranec - Nghia Truong (https://github.com/ttnghia) - Karthikeyan (https://github.com/karthikeyann) URL: #9076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If I try to do a row_bit_count on the attached file BIT_MAP_INPUT_1.parquet.gz (have to unzip it first), then I get Illegal memory access errors.
Steps/Code to reproduce bug
Apply the patch
and build it (but don't run).
unzip the attached file and place it in your current working directory. Then run
./gtests/TRANSFORM_TEST
from the test suite.Expected behavior
No crashes no Illegal memory access errors.
The text was updated successfully, but these errors were encountered: