Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support map types in ORC reader/writer #8826

Closed
2 tasks done
vuule opened this issue Jul 22, 2021 · 0 comments · Fixed by #9369
Closed
2 tasks done

[FEA] Support map types in ORC reader/writer #8826

vuule opened this issue Jul 22, 2021 · 0 comments · Fixed by #9369
Assignees
@vuule @rgsl888prabhu
Labels
cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Milestone
IO Data Type Expa...

Comments

@vuule
Copy link
Contributor

vuule commented Jul 22, 2021 •
edited
Loading

Map support:

  • Reader
  • Writer
@vuule vuule added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. cuIO cuIO issue labels Jul 22, 2021
@vuule vuule self-assigned this Jul 22, 2021
@vuule vuule changed the title [FEA] Support struct types in ORC writer [FEA] Support map types in ORC reader/writer Jul 22, 2021
@beckernick beckernick added this to the IO Data Type Expansion milestone Jul 26, 2021
@rgsl888prabhu rgsl888prabhu mentioned this issue Aug 27, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Sep 9, 2021
@rgsl888prabhu
Adding MAP type support for ORC Reader (#9132)
473063f 
Since cuDF still doesn't support MAP type, this will be viewed as  list of structs, and struct having key and value pair as members.

#8826 Completes Reader part of MAP support.

Authors:
  - Ram (Ramakrishna Prabhu) (https://github.com/rgsl888prabhu)

Approvers:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Devavret Makkar (https://github.com/devavret)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #9132
@vuule vuule mentioned this issue Oct 5, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #9369 Oct 7, 2021
rapids-bot bot pushed a commit that referenced this issue Oct 7, 2021
@vuule
Add support for writing ORC with map columns (#9369)
aaea353 
Closes #8826

Users can mark a list column as a map and ORC writer will write it into the output file as such.

Also removed some redundant code in Python tests, completely unrelated to the feature.

Authors:
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - Devavret Makkar (https://github.com/devavret)
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Ram (Ramakrishna Prabhu) (https://github.com/rgsl888prabhu)

URL: #9369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vuule vuule

@rgsl888prabhu rgsl888prabhu

Labels
cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
Milestone
IO Data Type Expansion
Development

Successfully merging a pull request may close this issue.

Add support for writing ORC with map columns vuule/cudf
3 participants
@beckernick @vuule @rgsl888prabhu