Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile has no cleaning commands [BUG] #881

Closed
karthikeyann opened this issue Feb 6, 2019 · 1 comment · Fixed by #6619
Closed

Dockerfile has no cleaning commands [BUG] #881

karthikeyann opened this issue Feb 6, 2019 · 1 comment · Fixed by #6619
Labels
bug Something isn't working

Comments

@karthikeyann
Copy link
Contributor

Describe the bug
The Dockerfile contains build commands but no corresponding clean commands.

Steps/Code to reproduce bug
Each layer size is bigger than its intended size due to storage space taken by temporary files.

Expected behavior
dockerfile best practices suggest to clean the temporary files after build/install in same RUN command. https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run
Otherwise, that layer will take more storage space.

Environment details (please complete the following information):

  • Environment location: [Docker]
  • Method of cuDF install: [ Docker build from source]

Additional context
add clean commands for all build commands generating temporary files.
@karthikeyann karthikeyann added Needs Triage Need team to review and classify bug Something isn't working labels Feb 6, 2019
@kkraus14 kkraus14 added code quality and removed Needs Triage Need team to review and classify labels Feb 13, 2019
@kkraus14
Copy link
Collaborator

kkraus14 commented Jul 3, 2019

@randerzander any ideas on how we can better maintain the Dockerfile here as opposed to the greater rapidsai Dockerfile?

@igormp igormp mentioned this issue Oct 29, 2020
Merged
@rapids-bot rapids-bot bot closed this as completed in #6619 Dec 2, 2020
rapids-bot bot pushed a commit that referenced this issue Dec 2, 2020
@igormp
Improve Dockerfile(#6619)
220c988 
Cleans up apt's cache after installing everything.

Also added the number of cores of the current machine in order to avoid an infinite amount of threads being spawned and using way too much RAM.

Fixes #881.

Authors:
  - Igor Moura <[email protected]>
  - Igor Moura <[email protected]>
  - Karthikeyan <[email protected]>

Approvers:
  - AJ Schmidt
  - Karthikeyan
  - AJ Schmidt

URL: #6619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Improve Dockerfile igormp/cudf
3 participants
@mike-wendt @kkraus14 @karthikeyann