Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] null_mask.cuh contains an anonymous namespace #8781

Closed
vyasr opened this issue Jul 19, 2021 · 0 comments · Fixed by #8786
Closed

[BUG] null_mask.cuh contains an anonymous namespace #8781

vyasr opened this issue Jul 19, 2021 · 0 comments · Fixed by #8786
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.

Comments

@vyasr
Copy link
Contributor

vyasr commented Jul 19, 2021 •
edited by harrism
Loading

@jrhemstad @nvdbaranec JFYI this PR looks like it got merged without addressing this. It's not a big deal but may be worth fixing in a follow-up to avoid the possibility of unexpected UB somewhere down the line.

https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL59-CPP.+Do+not+define+an+unnamed+namespace+in+a+header+file

Originally posted by @vyasr in #8738 (comment)
@harrism harrism changed the title null_mask.cuh contains an anonymous namespace [BUG] null_mask.cuh contains an anonymous namespace Jul 19, 2021
@vyasr vyasr added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. labels Jul 19, 2021
@vyasr vyasr mentioned this issue Jul 20, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 20, 2021
@nvdbaranec
Remove anonymous namespace from null_mask.cuh (#8786)
544cda2 
Removed a non-compliant anonymous namespace from `null_mask.cuh`.  The contents has been left in the `cudf::detail` namespace.

Resolves #8781

Authors:
  - https://github.com/nvdbaranec

Approvers:
  - Karthikeyan (https://github.com/karthikeyann)
  - MithunR (https://github.com/mythrocks)

URL: #8786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove anonymous namespace from null_mask.cuh nvdbaranec/cudf
1 participant
@vyasr