Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add support for "pad" as fill_method option for Series.fillna #8727

Closed
TravisHester opened this issue Jul 13, 2021 · 0 comments · Fixed by #8650
Closed

[FEA] Add support for "pad" as fill_method option for Series.fillna #8727

TravisHester opened this issue Jul 13, 2021 · 0 comments · Fixed by #8650
Assignees
@TravisHester
Labels
feature request New feature or request Python Affects Python cuDF API.

Comments

@TravisHester
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Series.fillna currently supports "ffill" as an option for fill_method which in pandas is the same as "pad", however the cudf version of Series.fillna does not currently support "pad" as a valid option.

Describe the solution you'd like
Series.fillna should support "pad" as an option for fill_method and treat it the same way as "ffill"
@TravisHester TravisHester added feature request New feature or request Python Affects Python cuDF API. labels Jul 13, 2021
@TravisHester TravisHester self-assigned this Jul 13, 2021
@TravisHester TravisHester mentioned this issue Jul 13, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 22, 2021
@TravisHester
Added pct_change to Series (#8650)
eddb2f8 
closes #6133
closes #8727
unit test in test_stats.py: test_series_pct_change

Added pct_change function for Series. The limit and freq arguments could not be fully implemented due to lack of implementation in Series.fillna() and Series.shift() functions respectively.

Authors:
  - https://github.com/TravisHester

Approvers:
  - Michael Wang (https://github.com/isVoid)
  - Benjamin Zaitlen (https://github.com/quasiben)

URL: #8650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TravisHester TravisHester

Labels
feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added pct_change to Series TravisHester/cudf
1 participant
@TravisHester