Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Series datetime is_quarter_end and is_quarter_start #8679

Closed
beckernick opened this issue Jul 7, 2021 · 0 comments · Fixed by #9046
Closed

[FEA] Series datetime is_quarter_end and is_quarter_start #8679

beckernick opened this issue Jul 7, 2021 · 0 comments · Fixed by #9046
Assignees
@TravisHester
Labels
feature request New feature or request good first issue Good for newcomers Python Affects Python cuDF API.
Milestone
Time Series Analysis

Comments

@beckernick
Copy link
Member

For feature engineering tasks, I'd like to be able to determine whether a datetime is the beginning or end of a quarter, like I can in pandas.

Possibly should follow #8676

import pandas as pd
​
s = pd.Series(["2021-02-27", "2020-03-31"], dtype="datetime64[ms]")
s.dt.is_quarter_end
0    False
1     True
dtype: bool
import pandas as pd
​
s = pd.Series(["2021-02-27", "2020-04-01"], dtype="datetime64[ms]")
s.dt.is_quarter_start
0    False
1     True
dtype: bool
@beckernick beckernick added feature request New feature or request Python Affects Python cuDF API. labels Jul 7, 2021
@beckernick beckernick added the good first issue Good for newcomers label Jul 14, 2021
@beckernick beckernick added this to the Time Series Analysis milestone Jul 14, 2021
@marlenezw marlenezw assigned marlenezw and unassigned marlenezw Aug 5, 2021
@TravisHester TravisHester self-assigned this Aug 16, 2021
@TravisHester TravisHester mentioned this issue Aug 16, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Aug 17, 2021
@TravisHester
Added Series.dt.is_quarter_start and Series.dt.is_quarter_end (#9046)
3402fec 
closes: #8679

Added `Series.dt` functions and tests for `is_quarter_start` and `is_quarter_end`.

Authors:
  - https://github.com/TravisHester
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Marlene  (https://github.com/marlenezw)

URL: #9046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TravisHester TravisHester

Labels
feature request New feature or request good first issue Good for newcomers Python Affects Python cuDF API.
Projects
None yet
Milestone
Time Series Analysis
Development

Successfully merging a pull request may close this issue.

Added Series.dt.is_quarter_start and Series.dt.is_quarter_end TravisHester/cudf
3 participants
@beckernick @TravisHester @marlenezw