Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Segfault when reading small zipped CSV files #8497

Closed
elstehle opened this issue Jun 11, 2021 · 2 comments · Fixed by #8498
Closed

[BUG] Segfault when reading small zipped CSV files #8497

elstehle opened this issue Jun 11, 2021 · 2 comments · Fixed by #8498
Assignees
@elstehle
Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code.

Comments

@elstehle
Copy link
Contributor

Describe the bug
There's an out-of-bounds memory access that is observed when reading in .zip files that are less than, approximately 64KB in size.

Steps/Code to reproduce bug

  1. Download the following zip file
wget http://data.gdeltproject.org/gdeltv2/20210513074500.export.CSV.zip
  1. Try to read in the downloaded zipped CSV file
import cudf
filename = '20210513074500.export.CSV.zip'
dfs = cudf.read_csv(filename, header=None, sep='\t')

Expected behavior
Data is read into cudf.
@elstehle elstehle added bug Something isn't working Needs Triage Need team to review and classify labels Jun 11, 2021
@elstehle elstehle self-assigned this Jun 11, 2021
@elstehle elstehle mentioned this issue Jun 11, 2021
Merged
@elstehle elstehle added libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Jun 14, 2021
@harrism harrism added the cuIO cuIO issue label Jun 14, 2021
@quasiben
Copy link
Member

Thanks @elstehle I was able to verify this is a bug. @harrism do you think this is an issue on the libcudf side ?

@elstehle
Copy link
Contributor Author

@quasiben thanks for verifying. I have investigated the issue and put up a PR which should fix this:
#8498

rapids-bot bot pushed a commit that referenced this issue Jun 17, 2021
@elstehle
Fixes out-of-bounds access for small files in unzip (#8498)
46c13c1 
This PR fixes #8497.

Authors:
  - Elias Stehle (https://github.com/elstehle)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - David Wendt (https://github.com/davidwendt)
  - Charles Blackmon-Luca (https://github.com/charlesbluca)
  - Vukasin Milovanovic (https://github.com/vuule)

URL: #8498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elstehle elstehle

Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes out-of-bounds access for small files in unzip elstehle/cudf
3 participants
@harrism @quasiben @elstehle