Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] null_equality config of rolling_collect_set doesn't work #8405

Closed
sperlingxx opened this issue May 31, 2021 · 0 comments · Fixed by #8415
Closed

[BUG] null_equality config of rolling_collect_set doesn't work #8405

sperlingxx opened this issue May 31, 2021 · 0 comments · Fixed by #8415
Assignees
@sperlingxx
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.

Comments

@sperlingxx
Copy link
Contributor

sperlingxx commented May 31, 2021 •
edited
Loading

Describe the bug
In current implementation of rolling_collect_set, we call lists::detail::drop_list_duplicates with hard-code parameters for null_equal and nan_equal by mistake, which disabled the two configs. (code link)

P.S. The bug is not that urgent, since it won't do harm to the downstream projects (spark-rapids).
@sperlingxx sperlingxx added bug Something isn't working Needs Triage Need team to review and classify labels May 31, 2021
@sperlingxx sperlingxx self-assigned this May 31, 2021
@sperlingxx sperlingxx added the libcudf Affects libcudf (C++/CUDA) code. label May 31, 2021
@shwina shwina removed the Needs Triage Need team to review and classify label May 31, 2021
@sperlingxx sperlingxx mentioned this issue Jun 1, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #8415 Jun 3, 2021
rapids-bot bot pushed a commit that referenced this issue Jun 3, 2021
@sperlingxx
Fix null_equality config of rolling_collect_set (#8415)
d8fbb19 
Fix #8405, and add some tests for various `null_equality` and `nan_equality`.

Authors:
  - Alfred Xu (https://github.com/sperlingxx)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - MithunR (https://github.com/mythrocks)

URL: #8415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sperlingxx sperlingxx

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix null_equality config of rolling_collect_set sperlingxx/cudf
2 participants
@shwina @sperlingxx