Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Update Java nvcomp bindings to nvcomp 2.x API #8336

Closed
jlowe opened this issue May 24, 2021 · 0 comments · Fixed by #9384
Closed

[FEA] Update Java nvcomp bindings to nvcomp 2.x API #8336

jlowe opened this issue May 24, 2021 · 0 comments · Fixed by #9384
Assignees
@jbrennan333
Labels
feature request New feature or request Java Affects Java cuDF API.

Comments

@jlowe
Copy link
Member

jlowe commented May 24, 2021

Is your feature request related to a problem? Please describe.
libcudf will be pulling in nvcomp 2.x as part of #8229, and #8334 worked around the conflict between 1.x and 2.x by statically linking the old nvcomp 1.x library. The nvcomp 1.x API has been abandoned, and the Java bindings should be updated to 2.x so we don't have to ship both the 1.x and 2.x versions of nvcomp.

Describe the solution you'd like
The Java nvcomp bindings should be updated to the nvcomp 2.x API and the nvcomp library dependency should be reused from the dependency libcudf is using.

Describe alternatives you've considered
We could maintain the 1.x bindings, but they are no longer supported in nvcomp. It is a burden to support two very different APIs and doing so requires shipping multiple versions of nvcomp.
@jlowe jlowe added feature request New feature or request Java Affects Java cuDF API. labels May 24, 2021
@jlowe jlowe self-assigned this May 24, 2021
@jlowe jlowe mentioned this issue May 24, 2021
Merged
@jlowe jlowe assigned jbrennan333 and unassigned jlowe Sep 7, 2021
This was referenced Oct 5, 2021
Closed
Merged
rapids-bot bot pushed a commit that referenced this issue Oct 26, 2021
@jbrennan333
Update Java nvcomp JNI bindings to nvcomp 2.x API (#9384)
063c982 
This PR Closes #8336 

The Java nvcomp JNI bindings are updated to the nvcomp 2.x API and the nvcomp library is no longer built as part of the Java build.  It is reused from the dependency that libcudf is using.

Note that the nvcomp 1.x API is no longer supported by the CUDF Java JNI, so this is a breaking change.  Spark-Rapids currently depends on the nvcomp 1.x JNI.  I will be putting up a PR for spark-rapids that changes it to use this 2.x JNI, which will need to be merged soon after this PR to minimize incompatibilities.

Authors:
  - Jim Brennan (https://github.com/jbrennan333)

Approvers:
  - Alessandro Bellina (https://github.com/abellina)
  - Jason Lowe (https://github.com/jlowe)

URL: #9384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbrennan333 jbrennan333

Labels
feature request New feature or request Java Affects Java cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Java nvcomp JNI bindings to nvcomp 2.x API jbrennan333/cudf
2 participants
@jlowe @jbrennan333