Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] incorrect assertion in stringConcatenate and listConcatenateByRow #8246

Closed
sperlingxx opened this issue May 14, 2021 · 0 comments · Fixed by #8258
Closed

[BUG] incorrect assertion in stringConcatenate and listConcatenateByRow #8246

sperlingxx opened this issue May 14, 2021 · 0 comments · Fixed by #8258
Assignees
@sperlingxx
Labels
bug Something isn't working Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS

Comments

@sperlingxx
Copy link
Contributor

Describe the bug
There exists incorrect assertion on length of input columns in both stringConcatenate and listConcatenateByRow. However, libcudf supports single column concatenation for both string and list_by_row. And single column concatenation is also valid in Spark.

Expected behavior
We should reduce the requirement of length from 2 to 1, so as to unblock single column inputs from Spark rapids.
@sperlingxx sperlingxx added bug Something isn't working Needs Triage Need team to review and classify Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS labels May 14, 2021
@sperlingxx sperlingxx self-assigned this May 14, 2021
This was referenced May 14, 2021
Closed
Merged
@jlowe jlowe removed the Needs Triage Need team to review and classify label May 14, 2021
@sperlingxx sperlingxx mentioned this issue May 17, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue May 19, 2021
@sperlingxx
Fix incorrect assertion in Java concat (#8258)
7af8966 
Fix #8246.

Authors:
  - Alfred Xu (https://github.com/sperlingxx)

Approvers:
  - Liangcai Li (https://github.com/firestarman)
  - Jason Lowe (https://github.com/jlowe)
  - Robert (Bobby) Evans (https://github.com/revans2)

URL: #8258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sperlingxx sperlingxx

Labels
bug Something isn't working Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect assertion in Java concat [skip ci] sperlingxx/cudf
2 participants
@jlowe @sperlingxx