Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] JNI: Creating a string column from arrays of UTF8 bytes #8137

Closed
firestarman opened this issue May 3, 2021 · 0 comments · Fixed by #8257
Closed

[FEA] JNI: Creating a string column from arrays of UTF8 bytes #8137

firestarman opened this issue May 3, 2021 · 0 comments · Fixed by #8257
Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS

Comments

@firestarman
Copy link
Contributor

firestarman commented May 3, 2021 •
edited
Loading

cudf cpp expects an UTF8 string to be dealt with. It is missing an API to create a ColumnVector from the arrays of UTF8 strings directly.
e.g.
public static ColumnVector fromUTF8Strings(byte[].... rows)

Also let the nested struct creation support UTF8 strings.
pubiic static ColumnVector fromStructs

This is low priority since now the API build can be used to achieve this.
@firestarman firestarman added feature request New feature or request Needs Triage Need team to review and classify labels May 3, 2021
@firestarman firestarman mentioned this issue May 3, 2021
Merged
@jlowe jlowe added Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS and removed Needs Triage Need team to review and classify labels May 3, 2021
@jlowe jlowe changed the title [FEA] JNI: Supports creating a ColumnVector from an array of UTF8 string directly. [FEA] JNI: Creating a string column from arrays of UTF8 bytes May 3, 2021
@davidwendt davidwendt mentioned this issue May 3, 2021
Closed
@firestarman firestarman mentioned this issue May 17, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue May 20, 2021
@firestarman
Create a String column from UTF8 String byte arrays (#8257)
2da8473 
This PR is to support creating a `ColumnVector ` from the byte arrays of UTF8 Strings.

And also let the `Struct` children creation support UTF8 Strings.

Closes #8137

Signed-off-by: Firestarman <[email protected]>

Authors:
  - Liangcai Li (https://github.com/firestarman)

Approvers:
  - Allen Xu (https://github.com/wjxiz1992)
  - Jason Lowe (https://github.com/jlowe)
  - Robert (Bobby) Evans (https://github.com/revans2)
  - Alfred Xu (https://github.com/sperlingxx)

URL: #8257
@firestarman firestarman mentioned this issue May 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a String column from UTF8 String byte arrays [skip ci] firestarman/cudf
2 participants
@jlowe @firestarman