Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add scalar support for struct #7790

Closed
razajafri opened this issue Mar 31, 2021 · 2 comments · Fixed by #8220
Closed

[FEA] Add scalar support for struct #7790

razajafri opened this issue Mar 31, 2021 · 2 comments · Fixed by #8220
Assignees
@nvdbaranec
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@razajafri
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This issue tracks discussion on how we can support a STRUCT scalar, which may need changes on the CPP side as well once we discuss what the layout should be.

Describe the solution you'd like
Ability to create a Scalar Struct

Describe alternatives you've considered
None.
@razajafri razajafri added feature request New feature or request Needs Triage Need team to review and classify labels Mar 31, 2021
@razajafri razajafri added the Spark Functionality that helps Spark RAPIDS label Mar 31, 2021
@jrhemstad jrhemstad changed the title [FEA] Add support for creating scalar STRUCT [FEA] Add scalar support for struct Mar 31, 2021
@jrhemstad
Copy link
Contributor

Related #5887

@kkraus14 kkraus14 added libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Apr 6, 2021
@kkraus14 kkraus14 mentioned this issue Apr 6, 2021
Closed
@gerashegalov gerashegalov mentioned this issue Apr 6, 2021
Closed
@sperlingxx sperlingxx mentioned this issue Apr 15, 2021
Closed
@github-actions
Copy link

github-actions bot commented May 6, 2021

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@nvdbaranec nvdbaranec mentioned this issue May 18, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue May 18, 2021
@nvdbaranec
Support for struct scalars. (#8220)
414e9bb 
Closes:  #7790

Creation of struct scalars.

Also in this PR:
- support for `struct_scalar` in `make_column_from_scalar`
- Refactored `superimpose_parent_nullmask` to be exposed as `structs::detail::superimpose_parent_nulls` in src/structs/utilities.hpp

Authors:
  - https://github.com/nvdbaranec

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Vukasin Milovanovic (https://github.com/vuule)
  - Robert Maynard (https://github.com/robertmaynard)

URL: #8220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvdbaranec nvdbaranec

Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for struct scalars. nvdbaranec/cudf
4 participants
@kkraus14 @razajafri @jrhemstad @nvdbaranec