Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] support null-excluded policy for collect aggregations in groupby #7777

Closed
sperlingxx opened this issue Mar 31, 2021 · 0 comments · Fixed by #8044
Closed

[FEA] support null-excluded policy for collect aggregations in groupby #7777

sperlingxx opened this issue Mar 31, 2021 · 0 comments · Fixed by #8044
Assignees
@sperlingxx
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@sperlingxx
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, under group_by::sort_aggregate context, collect aggregations (collect_list and collect_set) can only be used with null-included policy. But the collect aggregations are null-excluded`in Spark SQL. So, we need to support null-excluded policy for collect aggregations.
@sperlingxx sperlingxx added feature request New feature or request Needs Triage Need team to review and classify labels Mar 31, 2021
@jrhemstad jrhemstad added libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Mar 31, 2021
@jrhemstad jrhemstad changed the title [FEA] support null-excluded policy for collect aggregations [FEA] support null-excluded policy for collect aggregations in groupby Mar 31, 2021
@sperlingxx sperlingxx mentioned this issue Apr 1, 2021
Closed
21 tasks
@sperlingxx sperlingxx mentioned this issue Apr 23, 2021
Merged
@sameerz sameerz linked a pull request Apr 28, 2021 that will close this issue
Support exclude null_policy for collect list/set in groupby #8044
Merged
rapids-bot bot pushed a commit that referenced this issue May 13, 2021
@sperlingxx
Support exclude null_policy for collect list/set in groupby (#8044)
f8d7de4 
This pull request is to support `null_policy::EXCLUDE` for `collect_list`/`collect_set` in groupBy context, which is requested in  #7777.

Authors:
  - Alfred Xu (https://github.com/sperlingxx)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - David Wendt (https://github.com/davidwendt)
  - MithunR (https://github.com/mythrocks)

URL: #8044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sperlingxx sperlingxx

Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support exclude null_policy for collect list/set in groupby sperlingxx/cudf
2 participants
@sperlingxx @jrhemstad