Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] DataFrame.argsort returns internal object #7577

Closed
galipremsagar opened this issue Mar 12, 2021 · 0 comments · Fixed by #7706
Closed

[BUG] DataFrame.argsort returns internal object #7577

galipremsagar opened this issue Mar 12, 2021 · 0 comments · Fixed by #7706
Assignees
@galipremsagar
Labels
bug Something isn't working Python Affects Python cuDF API.

Comments

@galipremsagar
Copy link
Contributor

Describe the bug
We have argsort implemented for DataFrame object but it instead returns a non-public object i.e., Column which is internal to cudf.

Steps/Code to reproduce bug

>>> import cudf
>>> df = cudf.DataFrame({'a':[10, 0, 2], 'b':[-10, 10, 1]})
>>> df.argsort()
<cudf.core.column.numerical.NumericalColumn object at 0x7f23c38f6710>

Expected behavior
The output should be either an array / series.

Environment overview (please complete the following information)

  • Environment location: [Bare-metal]
  • Method of cuDF install: [from source]
@galipremsagar galipremsagar added bug Something isn't working Python Affects Python cuDF API. labels Mar 12, 2021
@galipremsagar galipremsagar self-assigned this Mar 12, 2021
@galipremsagar galipremsagar mentioned this issue Mar 24, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Mar 24, 2021
@galipremsagar
Fix return type of DataFrame.argsort (#7706)
df3c0f0 
Fixes: #7577 

This PR fixes the return type of `DataFrame.argsort` to return `cudf.Series` instead of a `NumericalColumn`.

Authors:
  - GALI PREM SAGAR (@galipremsagar)

Approvers:
  - Keith Kraus (@kkraus14)

URL: #7706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
bug Something isn't working Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Fix return type of DataFrame.argsort galipremsagar/cudf
1 participant
@galipremsagar