-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Refactor aggregation APIs #7456
Comments
I don't think it makes sense to group everything that touches |
Yes, it would be complex to combine everything to one. So, how about make them sub-categories? For example, we can have
Grouping the related APIs together make things easier to access and refer to. |
I still think that hurts more than it helps. The fact that a very diverse set of algorithms share a common |
Good point. Moreover, not all groupby operations are aggregations. Same goes for rolling. Suggest we close this as |
Currently, aggregation APIs (groupby, reductions, rolling, etc.) are scattered around in multiple files and there are inconsistencies between the directory structures in
cpp/include/
,cpp/src/
,cpp/tests/
, andcpp/benchmarks/
. For example:cpp/include/
:cpp/src/
:cpp/tests/
:I suggest to group all aggregation APIs together, so those APIs will be in
include/aggreation/*.*
,src/aggregation/*.*
,tests/aggregation/*.*
etc.The text was updated successfully, but these errors were encountered: