You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The aggregation class is used for specifying details of what kind of aggregation a user wants from APIs like groupby. User's should not need to interact with this class other than using the make_*_aggregation APIs to get an aggregation object.
Originally this type was opaque, but if I remember correctly, that broke Cython. So we had to make it non-opaque. However, this has lead to issues of users using methods of aggregation that they should not.
Describe the solution you'd like aggregation should be made more opaque. The PIMPL pattern is probably the right call here such that the type's definition is still visible to appease Cython, but it's members aren't available.
The text was updated successfully, but these errors were encountered:
This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.
This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.
Is your feature request related to a problem? Please describe.
The
aggregation
class is used for specifying details of what kind of aggregation a user wants from APIs likegroupby
. User's should not need to interact with this class other than using themake_*_aggregation
APIs to get anaggregation
object.Originally this type was opaque, but if I remember correctly, that broke Cython. So we had to make it non-opaque. However, this has lead to issues of users using methods of
aggregation
that they should not.Describe the solution you'd like
aggregation
should be made more opaque. The PIMPL pattern is probably the right call here such that the type's definition is still visible to appease Cython, but it's members aren't available.The text was updated successfully, but these errors were encountered: