Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] aggregation should be more opaque #6895

Open
jrhemstad opened this issue Dec 3, 2020 · 2 comments
Open

[FEA] aggregation should be more opaque #6895

jrhemstad opened this issue Dec 3, 2020 · 2 comments
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@jrhemstad
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The aggregation class is used for specifying details of what kind of aggregation a user wants from APIs like groupby. User's should not need to interact with this class other than using the make_*_aggregation APIs to get an aggregation object.

Originally this type was opaque, but if I remember correctly, that broke Cython. So we had to make it non-opaque. However, this has lead to issues of users using methods of aggregation that they should not.

Describe the solution you'd like
aggregation should be made more opaque. The PIMPL pattern is probably the right call here such that the type's definition is still visible to appease Cython, but it's members aren't available.

@jrhemstad jrhemstad added feature request New feature or request Needs Triage Need team to review and classify labels Dec 3, 2020
@kkraus14 kkraus14 added libcudf Affects libcudf (C++/CUDA) code. code quality and removed Needs Triage Need team to review and classify labels Dec 3, 2020
@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

No branches or pull requests

4 participants