Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add support for Series.drop #7045

Closed
galipremsagar opened this issue Dec 22, 2020 · 2 comments · Fixed by #7304
Closed

[FEA] Add support for Series.drop #7045

galipremsagar opened this issue Dec 22, 2020 · 2 comments · Fixed by #7304
Assignees
@isVoid
Labels
feature request New feature or request Python Affects Python cuDF API.

Comments

@galipremsagar
Copy link
Contributor

galipremsagar commented Dec 22, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
We currently have support for drop API in DataFrame but not in Series. I'd like to request support for drop in Series too for the ability to filter/drop out indices.

https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Series.drop.html#pandas.Series.drop
@galipremsagar galipremsagar added feature request New feature or request Python Affects Python cuDF API. labels Dec 22, 2020
@isVoid isVoid self-assigned this Feb 1, 2021
@isVoid
Copy link
Contributor

isVoid commented Feb 1, 2021

Looking into this issue.

@isVoid isVoid mentioned this issue Feb 4, 2021
Merged
4 tasks
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

rapids-bot bot pushed a commit that referenced this issue Mar 10, 2021
@isVoid
Add Series.drop api (#7304)
e628101 
Closes #7045 

This PR introduces `Series.drop` API. `Series.drop` allows users to drop certain elements in the series specified `labels` or `index` parameter.

Example:
```python3
>>> s = cudf.Series([1, 2, 3], index=['x', 'y', 'z'])
>>> s.drop(labels=['y'])
x    1
z    3
dtype: int64
```

- [x] Add series test case
- [x] Move common code path from `DataFrame.drop` to helper function
- [x] Add typing annotation
- [x] Add docstring

Authors:
  - Michael Wang (@isVoid)

Approvers:
  - Ashwin Srinath (@shwina)
  - GALI PREM SAGAR (@galipremsagar)

URL: #7304
hyperbolic2346 pushed a commit to hyperbolic2346/cudf that referenced this issue Mar 25, 2021
@isVoid @hyperbolic2346
Add Series.drop api (rapidsai#7304)
2818928 
Closes rapidsai#7045 

This PR introduces `Series.drop` API. `Series.drop` allows users to drop certain elements in the series specified `labels` or `index` parameter.

Example:
```python3
>>> s = cudf.Series([1, 2, 3], index=['x', 'y', 'z'])
>>> s.drop(labels=['y'])
x    1
z    3
dtype: int64
```

- [x] Add series test case
- [x] Move common code path from `DataFrame.drop` to helper function
- [x] Add typing annotation
- [x] Add docstring

Authors:
  - Michael Wang (@isVoid)

Approvers:
  - Ashwin Srinath (@shwina)
  - GALI PREM SAGAR (@galipremsagar)

URL: rapidsai#7304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isVoid isVoid

Labels
feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Series.drop api isVoid/cudf
2 participants
@galipremsagar @isVoid